chore: roll 1.51.0 driver, implement new features #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
changed the title
mxschmitt
approved these changes
Mar 6, 2025
mxschmitt
reviewed
Mar 7, 2025
| assertEquals(false, page.evaluate("() => matchMedia('(prefers-contrast: no-preference)').matches")); | ||
| } | ||
|
|
||
| static boolean tempDirCanBeOnDifferentRoot() { |
Contributor
There was a problem hiding this comment.
This looks phishy. Why this doesn't happen on the other language ports.
Member
Author
There was a problem hiding this comment.
This is java's implementation detail of file name relativization. The other ports probably handle it differently or their temp dir is on the same disk.
Member
Author
There was a problem hiding this comment.
The code was incorrect though, it's only for Windows and I accidentally committed isMac that I experimented with 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1731