chore: follow upstream url matcher #1717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
upstream-url-matcher-logic
branch
from
39957bb to
4a39417
Compare
mxschmitt
force-pushed
the
upstream-url-matcher-logic
branch
3 times, most recently
from
13c9b3b to
1d40fab
Compare
mxschmitt
force-pushed
the
upstream-url-matcher-logic
branch
from
1d40fab to
f27b75b
Compare
yury-s
reviewed
Dec 18, 2024
| static UrlMatcher forOneOf(URL baseUrl, Object object) { | ||
| if (object == null) { | ||
| return UrlMatcher.any(); | ||
| return new UrlMatcher(baseUrl, (String) null); |
Member
There was a problem hiding this comment.
This will only match baseURL while it was matching anything before.
| import static com.microsoft.playwright.impl.Utils.toJsRegexFlags; | ||
|
|
||
| class UrlMatcher { | ||
| final Object rawSource; |
Member
There was a problem hiding this comment.
Let's revert this part, it can be refactored in a separate change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715