Skip to content

test: unflake TestPageClock #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Nov 15, 2024
Merged

test: unflake TestPageClock #1699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion playwright/src/test/java/com/microsoft/playwright/TestPageClock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,9 @@ void shouldRunTimeBeforePopup(Page page, Server server) {
Page popup = page.waitForPopup(() -> {
page.evaluate("url => window.open(url)", server.PREFIX + "/popup.html");
});
popup.waitForURL(server.PREFIX + "/popup.html");
Double popupTime = (Double) popup.evaluate("time");
assertTrue(popupTime >= 2000);
assertTrue(popupTime >= 2000, "popupTime = " + popupTime);
}

@Test
Expand All @@ -310,6 +311,7 @@ void shouldNotRunTimeBeforePopupOnPause(Page page, Server server) {
Page popup = page.waitForPopup(() -> {
page.evaluate("url => window.open(url)", server.PREFIX + "/popup.html");
});
popup.waitForURL(server.PREFIX + "/popup.html");
Copy link
Contributor

@mxschmitt mxschmitt Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like upstream does waitForLoadState? https://github.com/microsoft/playwright/blob/77dee44984af1cd5b7c1ec4f6ed6fe022c7c55e6/tests/library/page-clock.spec.ts#L357

Copy link
Member Author

@yury-s yury-s Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for url does wait for load state too by default and also ensures we are not on about:blank (unlikely).

Object popupTime = popup.evaluate("time");
assertEquals(1000, popupTime);
}
Expand Down
Loading