fix: Omnisharp dynamic arguments are not escaped#111
Merged
LakshyAAAgrawal merged 3 commits intomicrosoft:mainfrom Apr 9, 2026
Merged
fix: Omnisharp dynamic arguments are not escaped#111LakshyAAAgrawal merged 3 commits intomicrosoft:mainfrom
LakshyAAAgrawal merged 3 commits intomicrosoft:mainfrom
Conversation
LakshyAAAgrawal
approved these changes
Apr 9, 2026
Collaborator
|
Thank you so much @Marti2203 for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I was experimenting a little with the library and saw that the arguments passed to Omnisharp are not escaped. This can cause problems for projects which contain whitespace in the path names, e.g.
proj/a b/file name.sln.Furthermore, I see this issue in other LSP invocation commands, can also add this to the PR if you want.