FIX: Optimizing test run time without impacting coverage

[subrata-ms]

Work Item / Issue Reference

AB#41135

GitHub Issue: #<ISSUE_NUMBER>

---

Summary

This pull request refactors and optimizes the tests/test_013_SqlHandle_free_shutdown.py test suite to improve test execution speed and maintainability. The main changes include reducing iteration counts and timeouts for faster test runs, and consolidating several similar tests into a single parameterized test using pytest.mark.parametrize. This makes the tests more efficient and easier to manage.

Test performance improvements:

• Reduced the number of iterations in connection churn and GC cycles, and lowered subprocess timeouts from 30 seconds to 5 seconds across multiple tests for much faster execution. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

Test suite maintainability:

• Combined multiple similar tests for _cleanup_connections() into a single parameterized test using pytest.mark.parametrize, reducing code duplication and improving readability. The scenarios now covered are: normal flow, already closed connections, missing _closed attribute, exception handling, multiple connections, and WeakSet behavior. [1] [2] [3] [4] [5] [6]

Test framework modernization:

• Added pytest import and usage to support parameterized testing.

Test output and assertion updates:

• Updated test assertions and output strings to match the new, reduced iteration counts and to ensure test correctness after refactoring. [1] [2] [3]

These changes make the test suite faster, more robust, and easier to extend in the future.

[Copilot]

Pull request overview

This pull request optimizes test execution time in two test files without compromising test coverage. The optimization strategy includes reducing iteration counts, lowering subprocess timeouts, and consolidating repetitive tests into parameterized test cases using pytest.mark.parametrize.

Key Changes:

• Reduced subprocess timeout values from 30 seconds to 3-5 seconds across multiple tests
• Consolidated 8 separate _cleanup_connections() test methods into a single parameterized test with 8 scenarios
• Parameterized multiple similar Unicode/UTF-8 test cases for better maintainability
• Reduced iteration counts in stress tests (e.g., 10→5, 5→2 GC cycles) and string length tests (e.g., 10000→1000 characters)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/test_013_SqlHandle_free_shutdown.py	Added pytest import; reduced iteration counts and subprocess timeouts; consolidated 8 _cleanup_connections() tests into a single parameterized test; updated assertions to match new iteration counts
tests/test_014_ddbc_bindings_coverage.py	Refactored multiple test methods into parameterized tests using @pytest.mark.parametrize; reduced long string test sizes for faster execution; consolidated UTF-8 encoding/decoding tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

📊 Code Coverage Report

🔥 Diff Coverage 100%

🎯 Overall Coverage 76%

📈 Total Lines Covered: 5379 out of 7037 📁 Project: mssql-python

---

Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

---

📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)

mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.helpers.py: 67.5%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.connection.py: 83.9%
mssql_python.cursor.py: 84.4%
mssql_python.__init__.py: 84.9%

---

🔗 Quick Links

⚙️ Build Summary	📋 Coverage Details
View Azure DevOps Build	Browse Full Coverage Report