bugfix: add theap->tld null check#1289
Open
p2kyc0ng wants to merge 1 commit intomicrosoft:dev3from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to issues 1288
possible trigger condition:
after _mi_thread_done (the pthread destructor) completes execution on a thread, the same thread continues to execute other destructors or callbacks. this triggers a mi_free on an abandoned page, which then enters mimalloc re-entrantly via __emutls_get_address → malloc. at this point, the theap returned by _mi_theap_default() is already in a corrupted/invalid state.
changes:
added a temporary null check for theap->tld. under this edge case, the allocator can safely fall back to subproc_main.