Add a note about relative links in MarkupContent#1443
Add a note about relative links in MarkupContent#1443DanTup wants to merge 3 commits intomicrosoft:gh-pagesfrom
Conversation
|
@dbaeumer I think in the client I want to add this in protocolConverter.ts's Is there a better way/place I can implement this? (Ideally, we could do it centrally/generically, detect the request has a document URI?). |
|
@dbaeumer I started looking at this again today and realised that it's not as simple as I first thought. The documentation being rendered in a hover or code completion results might contain paths that are relative to the document containing the markdown, not relative to the document triggering the hover/completion (eg. you could be completing or hovering symbols from another file). So I think this either needs to be handled in the servers (they rewrite the paths), or LSP allows the base URI to be included in MarkdownString? (the latter avoids the server having to parse Markdown). |
@dbaeumer is this what you had in mind for microsoft/vscode#142051 (comment)?
I don't know if MarkupContent is currently supported anywhere that isn't tied to a request for a document, but it probably makes sense to have this caveat?