Skip to content

serialize objects to bytes in a JSON compatible way #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkodev merged 5 commits into from
Mar 24, 2025
Merged

serialize objects to bytes in a JSON compatible way #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb25dff
Update json_parse_node.py
GeorgeOG Mar 22, 2025
d6c2c88
tests
Mar 23, 2025
e5e433b
except strings
Mar 23, 2025
437b975
except strings
Mar 23, 2025
74d27ec
test
Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/serialization/json/kiota_serialization_json/json_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,10 @@ def get_bytes_value(self) -> Optional[bytes]:
Returns:
bytearray: The bytearray value from the nodes
"""
base64_string = str(self._json_node)
if isinstance(self._json_node, str):
base64_string = self._json_node
else:
base64_string = json.dumps(self._json_node)
if not base64_string:
return None
return base64_string.encode("utf-8")
Expand Down
7 changes: 7 additions & 0 deletions packages/serialization/json/tests/unit/test_json_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ def test_get_bytes_value():
parse_node = JsonParseNode("U2Ftd2VsIGlzIHRoZSBiZXN0")
result = parse_node.get_bytes_value()
assert isinstance(result, bytes)
assert result.decode("utf-8") == "U2Ftd2VsIGlzIHRoZSBiZXN0"


def test_get_bytes_json_compatible():
parse_node = JsonParseNode({"test": 1})
result = parse_node.get_bytes_value()
assert json.loads(result.decode("utf-8")) == {"test": 1}


def test_get_collection_of_enum_values():
Expand Down