Fix base_url usage in HttpxRequestAdapter #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#374 Modify `HttpxRequestAdapter` to use `http_client.base_url` if `base_url` is not explicitly set. * Update the constructor in `packages/http/httpx/kiota_http/httpx_request_adapter.py` to check and use `http_client.base_url` if `base_url` is not provided. * Update the `base_url` property to return `http_client.base_url` if `_base_url` is not set. * Add a test in `packages/http/httpx/tests/test_httpx_request_adapter.py` to verify that `HttpxRequestAdapter` uses `http_client.base_url` if `base_url` is not explicitly set. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/kiota-python/issues/374?shareId=XXXX-XXXX-XXXX-XXXX).
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
Thanks for the contribution here @svrooij
Any chance you can update the commit message to follow this to help with automation of the changelog/release generation. https://github.com/microsoft/kiota-python/blob/main/CONTRIBUTING.md#commit-message-format
baywet
requested changes
Jan 27, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
For others reading, I took the time to check this property actually exists:
https://github.com/encode/httpx/blob/10b7295922741b91a15751029e6ad3e8e5efb9f3/httpx/_client.py#L295
baywet
approved these changes
Jan 28, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
baywet
previously approved these changes
Jan 28, 2025
baywet
previously approved these changes
Jan 28, 2025
baywet
approved these changes
Jan 28, 2025
|
release-please
bot
removed
the
release-please:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374
Modify
HttpxRequestAdapterto usehttp_client.base_urlifbase_urlis not explicitly set.packages/http/httpx/kiota_http/httpx_request_adapter.pyto check and usehttp_client.base_urlifbase_urlis not provided.base_urlproperty to returnhttp_client.base_urlif_base_urlis not set.packages/http/httpx/tests/test_httpx_request_adapter.pyto verify thatHttpxRequestAdapteruseshttp_client.base_urlifbase_urlis not explicitly set.For more details, open the Copilot Workspace session.