Skip to content

Fixes Retry Handler delay validation, retry count validation and exponential backoff #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ndiritu merged 4 commits into from
Dec 2, 2024
Merged

Fixes Retry Handler delay validation, retry count validation and exponential backoff #417

Ndiritu merged 4 commits into from
Dec 2, 2024

Conversation

@Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Dec 2, 2024 •
edited
Loading

  • Ensure calculated retry delay validated against correct maximum delay of 180 secs
  • Fixes retry handler exponential back-off to consider the delay specified in the retry handler option
  • Ensures retry count is incremented based on value in retry-attempt header to prevent exceeding configured max retries

closes #409

@Ndiritu Ndiritu self-assigned this Dec 2, 2024
@Ndiritu Ndiritu requested a review from a team as a code owner December 2, 2024 11:06
@Ndiritu Ndiritu marked this pull request as draft December 2, 2024 11:11
@Ndiritu Ndiritu changed the title Ensure calculated retry delay validated against correct maximum delay of 180 secs Fixes Retry Handler delay validation, retry count validation and exponential backoff Dec 2, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ndiritu Ndiritu marked this pull request as ready for review December 2, 2024 12:21
@Ndiritu Ndiritu merged commit 12a11f6 into main Dec 2, 2024
52 checks passed
@Ndiritu Ndiritu deleted the fix/retry-handler branch December 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

Assignees

@Ndiritu Ndiritu

Labels

None yet

Projects

Kiota
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RetryHandlerOption incorrect max_delay default logic

3 participants

@Ndiritu @baywet