Enhance ParseNodeFromStringTrait to handle fractional seconds in serialization

[DanClarke-io]

Added regex to strip fractional seconds from interval strings.

This is caused when a value like PT33.48S is passed to the parseDateIntervalFromString() function, and causes a fatal error:

Unknown or bad format (PT33.48S) #0 /opt/vendor/microsoft/kiota-abstractions/src/Serialization
ParseNodeFromStringTrait.php(27): DateInterval->__construct('PT33.48S') 
#1 /opt/vendor/microsoft/kiota-serialization-json/src/JsonParseNode.php(296):
\Kiota\Serialization\Json\JsonParseNode->parseDateIntervalFromString('PT33.48S')

[baywet]

Thanks for the contribution!

Can you please add unit tests to prevent future regressions?

[DanClarke-io]

@baywet I'm not completely au fait with unit tests, could you please ensure I've put them in correctly? The output was as follows:

$ ./vendor/bin/phpunit --filter ParseNodeTraitTest
PHPUnit 9.6.25 by Sebastian Bergmann and contributors.

Warning:       No code coverage driver with path coverage support available

......                                                              6 / 6 (100%)

Time: 00:00.029, Memory: 8.00 MB

OK (6 tests, 13 assertions)

If so, then the requested changes have been made.

[baywet]

Thank you for making the changes!

[baywet]

@DanClarke-io there are linting issues now that I've rebased the PR, would you mind having a look at it please?

[baywet]

Thank you for making the changes!

[baywet]

@DanClarke-io I think we're missing a null check so the risk of a null reference exception is mitigated, can you made another update please?

[DanClarke-io]

Hi @baywet, I'm hoping this is correct, I usually work as a solo developer, so if I've put this in wrong, please do let me know so I can learn for the future :)

[baywet]

No worries, I'm far from a PHP expert either. Last time I did production PHP, PHP 4 was "new" 😊

[DanClarke-io]

Ah I understand your requests now, thank you for the code review!

[baywet]

Thank you for making the changes!

[baywet]

Thank you for making the changes!

[baywet]

@DanClarke-io sorry for the chaotic review here, one unit test is failing again packages/abstractions/tests/Serialization/ParseNodeTraitTest.php:75, would you mind looking into it please?