bugfix for lancedb uri parsing when using an object store #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-sajid-ali
force-pushed
the
bugfix/lancedb_uri_parse
branch
2 times, most recently
from
ee4f7e8 to
41c7af6
Compare
s-sajid-ali
force-pushed
the
bugfix/lancedb_uri_parse
branch
from
41c7af6 to
f07fb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
db_urifor an object store is passed to lancedb, graphrag config parser implicitly converts it to a filesystem path. This PR fixes that and also incorporates #1991Related Issues
Will fix #328 (comment) and will implicitly address #1306
Proposed Changes
Only convert db_uri to a filesystem path if it does not start with a well known object store prefix (viz.
az,gs,s3). lancedb uri docs for object storesChecklist