Really mention the winget and homebrew PR URLs in the respective workflow runs' summary #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's _really_ display the PR URL in the workflow run's summary page (I did make that change, and it was tagged as v1.5, but I had forgotten to compile the Typescript, therefore the JavaScript code still did the old things and hid the PR URL in the run's logs). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I tried to change this workflow before so that it would show the winget PR URL in the workflow run's summary page. But I messed up, not realizing that `wingetcreate.exe submit` would output _multiple_ lines, and therefore simply prefixing the output with `::notice::...` would only elevate the first line of that output to the run's summary page (and naturally, the PR URL is not part of that). Bite the bullet and parse the output to extract the URL, and then show that as intended. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Nov 12, 2025
Member
mjcheetham
left a comment
mjcheetham
left a comment
There was a problem hiding this comment.
If this still doesn't work then my only other thought is that Write-Host may not be captured by the Actions runner, in which case Write-Output would need needed instead.
Member
Author
Good point @mjcheetham! But this PR replaces a |
dscho
deleted the
really-mention-winget-and-homebrew-pr-urls-in-summary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had already tried to achieve the same in #807, but neither winget nor homebrew patch worked as intended. This here PR hopefully fixes that (we will see in the v2.52.0 release...).