[DRAFT] Stabilizing Streams #1461
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Streams API Work in progress * Streams - sector aligned bufferpool for index work in progress * sector aligned bufferpool integration works * testing code wip * bug fixed * fixed major bug in btree * updates * fixed memory alloc by reverting to Marshal.AllocHGlobal * code cleanup * delete passes * tying up the streams API * added command to RespCommandsInfo * basic test with XADD and XLEN works * added XRANGE and XDEL - basic tests work * fixed bug with stream id parsing/encode/decode * added ACL Tests * added RespStreamTests * minor cleanup * added cleaner command strings for incorrect arguments * cleanup; removed TRIM code * cleanup; added more documentation about node structure * more cleanup * reverted visibility change to ByteArrayComparer to instead use .Instance * removed most of Unsafe.AsPointer() instances from BTree code * swapped out memory allocation for B-tree to use NativeMemory.AlignedAlloc instead of Marshal.AllocHGlobal * cleanup; removed unused imports + commented out code. * bug fix - mismatch in allocates v/s deallocates for B-tree * updates fixing PR comments * reverted an earlier change in Build.props following PR comment + changes to fix build errors. * applied changes to propagate modified RESP3 output * added streams as an optional * formatting fixes * minor edit * fixed minor bug in keeping streams optional * cleanup * updated XADD to return bulk string * minor edits to error messages; used WriteAsciiBulkString for stream id output after XADD * added back code for BTreeTrim (work in progress) * fixed validCount bug in TrimByLength * fuxed bug on validCount propagation + trimByID * minor bug fix; added BTreeTrimTests * return headValidKey as ReadOnlySpan<byte> * cleanup * connecting XTRIM to Streams API * added XTrimTests * stream commands error out in case streams is disabled * cleanup + switched to ReadOnlySpan<byte> instead of byte[] where applicable * matched error messages to Redis documentation * added NOMKSTREAM support for XADD * updated docs * minor cleanup + refactor variable name * minor edit * minor bug fix - enableStreams for ACL tests in server setup * support exact and approximate trimming of index * added support for approximate trimming * minor doc update
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original BTree and Streams code was written in the research branch by Raman Aneesh, and can be found in streams-original branch.
This PR aims to stabilize it with bugfixes, new features, and performance tuning.
Done
TODO