feat(web-components): add keyboard support for printable characters in Dropdown#36232
Open
marchbox wants to merge 17 commits into
Open
feat(web-components): add keyboard support for printable characters in Dropdown#36232marchbox wants to merge 17 commits into
marchbox wants to merge 17 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
marchbox
changed the title
radium-v
requested changes
May 26, 2026
| } | ||
|
|
||
| if (!increment) { | ||
| if (!this.isCombobox && e.key.length === 1 && e.key !== ' ' && !e.ctrlKey && !e.metaKey && !e.altKey) { |
Contributor
There was a problem hiding this comment.
What's the behavior with VoiceOver/Narrator when a key combination is expected to open/close the listbox?
Contributor
Author
There was a problem hiding this comment.
When the combobox (button) is focused, and the listbox is in closed state, pressing "a", VoiceOver will announce the menuitem since it instantly gains focus. Tested in VoiceOver, it announces in the same way as the APG’s example.
marchbox
force-pushed
the
users/machi/dropdown-typeahead
branch
from
bc03e45 to
aebd883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In Dropdown, when
type="dropdown", typing doesn’t move active descendant to an option whose label text starts with the user typed content.New Behavior
When Dropdown has the focus:
This behavior matches the native
<select>, ARIA Authoring Practices Guide, and Fluent React Dropdown.Related Issue(s)
Fixes #36122