feat(react-progress): migrate ProgressBar from CSS to motion components#35883
Open
robertpenner wants to merge 3 commits intomicrosoft:masterfrom
Open
feat(react-progress): migrate ProgressBar from CSS to motion components#35883robertpenner wants to merge 3 commits intomicrosoft:masterfrom
robertpenner wants to merge 3 commits intomicrosoft:masterfrom
Conversation
2b62711 to
9e32153
Compare
…BarIndeterminateMotion for consistency
📊 Bundle size reportUnchanged fixtures
|
…rogressBarMotions
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previous Behavior
@keyframesthat animated theleftstyle property.leftanimation triggers layout recalc, the animation ran on the main thread and was susceptible to jank.@keyframesand@media (prefers-reduced-motion: reduce).New Behavior
translateinstead ofleft, making the animation run on the compositor thread and jank-proof.reducedMotionoption.Code Changes
progressBarMotions.tswith aProgressBarIndeterminateMotionmotion componentrenderProgressBar.tsxto wrap the bar slot with the motion component whenvalueisundefined(indeterminate)@keyframesanimations and related styles fromuseProgressBarStyles.styles.ts@fluentui/react-motionas a dependencyTesting
left-based CSS animation becomes choppy when the main thread is busy.translate-based motion component runs smoothly without disruption.