feat(react-spinner): migrate Spinner animations to motion components#35882
Draft
robertpenner wants to merge 1 commit intomicrosoft:masterfrom
Draft
feat(react-spinner): migrate Spinner animations to motion components#35882robertpenner wants to merge 1 commit intomicrosoft:masterfrom
robertpenner wants to merge 1 commit intomicrosoft:masterfrom
Conversation
📊 Bundle size report
Unchanged fixtures
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 600 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 158 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 504 | Changed |
vr-tests-react-components/Spinner converged 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Spinner converged.Inverted - High Contrast.default.chromium.png | 150 | Changed |
| vr-tests-react-components/Spinner converged.Inverted with Label - Dark Mode.default.chromium.png | 350 | Changed |
| vr-tests-react-components/Spinner converged.Animation - RTL.default.chromium.png | 4485 | Changed |
| vr-tests-react-components/Spinner converged.Inverted with Label - High Contrast.default.chromium.png | 920 | Changed |
| vr-tests-react-components/Spinner converged.Inverted.default.chromium.png | 78 | Changed |
| vr-tests-react-components/Spinner converged.Inverted with Label.default.chromium.png | 311 | Changed |
| vr-tests-react-components/Spinner converged.Animation.default.chromium.png | 4998 | Changed |
| vr-tests-react-components/Spinner converged.Primary - Dark Mode.default.chromium.png | 53 | Changed |
| vr-tests-react-components/Spinner converged.Primary - High Contrast.default.chromium.png | 122 | Changed |
| vr-tests-react-components/Spinner converged.Primary with Label - RTL.default.chromium.png | 220 | Changed |
| vr-tests-react-components/Spinner converged.Primary + size.default.chromium.png | 462 | Changed |
| vr-tests-react-components/Spinner converged.Primary with Label - Dark Mode.default.chromium.png | 112 | Changed |
| vr-tests-react-components/Spinner converged.Primary.default.chromium.png | 70 | Changed |
| vr-tests-react-components/Spinner converged.Primary with Label - High Contrast.default.chromium.png | 361 | Changed |
| vr-tests-react-components/Spinner converged.Primary with Label.default.chromium.png | 314 | Changed |
| vr-tests-react-components/Spinner converged.Spinner Min Width.default.chromium.png | 78 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)