fix(react-checkbox): preserve slot onChange handler using mergeCallbacks#35877
Open
karesansui-u wants to merge 1 commit intomicrosoft:masterfrom
Open
fix(react-checkbox): preserve slot onChange handler using mergeCallbacks#35877karesansui-u wants to merge 1 commit intomicrosoft:masterfrom
karesansui-u wants to merge 1 commit intomicrosoft:masterfrom
Conversation
useCheckbox used direct assignment with useEventCallback to set the input onChange handler, which silently dropped any custom onChange passed via the input slot prop. Switch to mergeCallbacks to preserve slot handlers, matching the pattern used by Radio and Switch.
Author
|
@microsoft-github-policy-service agree |
dmytrokirpa
approved these changes
Mar 18, 2026
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1208 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 488 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 487 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1090 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 599 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 605 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 39 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 837 | Changed |
vr-tests-react-components/Skeleton converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png | 24 | Changed |
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle.default.chromium.png | 6 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useCheckbox_unstableuses direct assignment (state.input.onChange = useEventCallback(...)) which silently drops any customonChangepassed via theinputslot prop.For example,
<Checkbox input={{ onChange: customHandler }} />—customHandleris never called.New Behavior
Uses
mergeCallbacks(state.input.onChange, ...)to preserve custom slot handlers, matching the pattern used by sibling components:useRadio.tsx:61):input.onChange = mergeCallbacks(input.onChange, ev => ...)useSwitch.tsx:81):input.onChange = mergeCallbacks(input.onChange, ev => ...)Related Issue(s)
None found — this is a previously unreported inconsistency.