-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Chart gradients work #35873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v-baambati
wants to merge
85
commits into
microsoft:master
Choose a base branch
from
v-baambati:chart-gradients-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chart gradients work #35873
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
e5e79fc
add gradient declarations
shawn-grant b362372
replace color with gradient in ChartDataPoint and add gradient utilit…
shawn-grant 758f388
refactor: update test-data.ts dataPoints to use gradient property
shawn-grant 09b1252
feat: implement gradient support in DonutChart components
shawn-grant eef1cf2
test: update DonutChart tests to use gradient instead of color
shawn-grant 0c562b5
feat: add gradient support to HorizontalBarChart and update rendering…
shawn-grant 2eb7d67
refactor: replace color with gradient in HorizontalBarChart test cases
shawn-grant 942d9a3
build: update charts api readme
shawn-grant d3cc0db
add update-snapshots script to package.json
shawn-grant 5d90039
update tests and test snapshot
shawn-grant f64134a
Merge branch 'master' into chart-gradients
shawn-grant d9aa34d
refactor: update all DonutChart stories to use gradient pallete
shawn-grant 40f628c
refactor: update HorizontalBarChart stories to use gradient palette
shawn-grant 355faa6
Merge branch 'master' into chart-gradients
shawn-grant 18988c5
fix HBC test snapshots
shawn-grant 61e5ad7
update change files
shawn-grant fc6d1c4
update change files
shawn-grant e10f630
Merge branch 'chart-gradients' of https://github.com/shawn-grant/flue…
shawn-grant 8a3d7bf
update change type to patch
shawn-grant 751e2e0
Merge branch 'master' into chart-gradients
shawn-grant c58d7af
build: fix formatting issues
shawn-grant 0cc5413
build: fix ci fail (vr-tests-react-components)
shawn-grant f75812e
add change file
shawn-grant 78f2709
Merge branch 'master' into chart-gradients
shawn-grant 0138bed
pr-fix(HorizontalBarChart): use tokens.colorBackgroundOverlay
shawn-grant 610b397
feat(DonutChart): update gradient calculation and add custom gradient…
shawn-grant f01a57a
feat(HorizontalBarChart): add custom gradient story
shawn-grant 7961be6
pr-fix(DonutChart): check both gradient colors are defined before app…
shawn-grant 904d04f
update test snapshots
shawn-grant 8a6ce72
pr-fix(DonutChart): rename gradient prop to color for Arc
shawn-grant 969f516
pr-fix(DonutChart): rename gradient prop to color and update related …
shawn-grant dcf5e3d
pr-fix(HorizontalBarChart): rename gradient prop to color and update …
shawn-grant 026000b
revert changes in vr-tests-react-components
shawn-grant 25c7e0f
update tests
shawn-grant 1f7ca56
Merge branch 'master' into chart-gradients
shawn-grant 40ee893
pr-cleanup: revert changes in @fluentui/react-virtualizer
shawn-grant e15353b
fix tests
shawn-grant 6c15c0d
minor change
shawn-grant 6ecf234
pr-fix(charts): improve missing color handling
shawn-grant 3d9a7e2
Merge branch 'master' into chart-gradients
shawn-grant 81890dc
Merge branch 'master' into chart-gradients
shawn-grant 5057918
Merge branch 'master' into chart-gradients
shawn-grant 1168c3b
Merge branch 'master' into chart-gradients
shawn-grant 87941da
Merge branch 'master' into chart-gradients
shawn-grant 0e00ef8
resolved conflicts
v-baambati 17f34ca
resolved conflicts
v-baambati bd9628f
resolved conflicts
v-baambati da704db
resolved conflicts
v-baambati 7c8a980
resolved conflicts
v-baambati 4989ef1
resolved merge conflicts
v-baambati aebf3cf
fixed build errors
v-baambati 01e4331
updated Donut charts and Horizontal bar chart snaps
v-baambati 85a2bd0
added change log file
v-baambati 2f6fabb
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
v-baambati 0d75765
Enabled gradient functionality
v-baambati 672dde0
Enabled gradient functionality
v-baambati 208ad19
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
v-baambati 5571a0a
fixed build issues
v-baambati dbdd836
fixed build issues
v-baambati 04de6e7
fixed build issues
v-baambati dfae458
fixed data mismatch issue
v-baambati 2bb2bcf
removed unwanted console statement
v-baambati c30f76d
updated snaps for failed tests
v-baambati 2dc2921
disabled vega test
v-baambati e430b65
disabled vega test
v-baambati ebb0c5b
fixed lint errors
v-baambati c190c6a
removed unwanted test file for testing
v-baambati 8510299
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
v-baambati 228a965
Merge branch 'chart-gradients-work' of https://github.com/v-baambati/…
v-baambati e41a1cb
fixed swift lint issues
v-baambati 87edd37
fixed swift lint issues
v-baambati d72e3be
fixed lint issue in Horizontalbarchart example
v-baambati 7f8412e
fixed callout color issue when gradient enabled in Grouped verticalBa…
v-baambati d8229f4
added gradient functility to Dinut chart and Horizontalbarchartwith axis
v-baambati 89ab82b
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
v-baambati 58b51a7
added gradient functility to Dinut chart and Horizontalbarchartwith axis
v-baambati a0b4458
updated snapshots
v-baambati 0e198b8
updated react-charts api
v-baambati 756d9db
Enabled gradient functiaonlity in Area chart
v-baambati bb2157b
added gradient funtioanlity in ganttchartbasic example
v-baambati 36aa01c
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
v-baambati 91b2b0f
updated vega chart tests
v-baambati 523b9ba
added basic test cases to validate gradient funtionality
v-baambati 07e6945
added basic test cases to validate gradient funtionality
v-baambati 4f49fd4
removed unwanted file chnages
v-baambati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-charts-46eac20b-5c72-486d-a803-d2e37cc8b097.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Added gradiant color functiaonlity in Donut chart and horizontalbarchart", | ||
| "packageName": "@fluentui/react-charts", | ||
| "email": "132879294+v-baambati@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-charts-preview-4a4fc3a5-16b8-4e2c-9fea-5cb5888e977f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Introduce gradients and rounded corners to v9 charts", | ||
| "packageName": "@fluentui/react-charts-preview", | ||
| "email": "shawngrant333@gmail.com", | ||
| "dependentChangeType": "patch" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
vr-tests-react-components/CalendarCompat 4 screenshots
vr-tests-react-components/Charts-DonutChart 2 screenshots
vr-tests-react-components/Charts-HorizontalBarChart 10 screenshots
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
vr-tests-react-components/Positioning 2 screenshots
vr-tests-react-components/ProgressBar converged 2 screenshots
vr-tests-react-components/TagPicker 2 screenshots
There were 4 duplicate changes discarded. Check the build logs for more information.