fix(toggle-button): prevent outline toggle from increasing button size#35698
Draft
robertpenner wants to merge 4 commits intomicrosoft:masterfrom
Draft
fix(toggle-button): prevent outline toggle from increasing button size#35698robertpenner wants to merge 4 commits intomicrosoft:masterfrom
robertpenner wants to merge 4 commits intomicrosoft:masterfrom
Conversation
robertpenner
changed the title
…hen outline is selected
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 39 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 512 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Use strokeWidthThin for focus shadow to layer correctly over strokeWidthThick border shadow when checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a visual bug in the
@fluentui/react-buttonpackage where toggling the outline appearance on aToggleButtonwould cause the button size to increase. The fix ensures the outline effect does not affect the button's layout by using an inset box-shadow instead of a thicker border. Additionally, styles are refactored to ensure consistent transitions and appearance handling.Bug fix and styling improvements:
ToggleButtons to use an insetbox-shadowinstead of increasing the border width, preventing layout shifts when toggling the button.useRootAppearanceStyleshook to manage appearance-related base styles, including smooth transitions for box-shadow and other properties.