-
Notifications
You must be signed in to change notification settings - Fork 2.9k
refactor(react-button): streamline button component base hook and remove unused base hooks #35689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hotell
merged 4 commits into
microsoft:master
from
dmytrokirpa:refactor/button-state-hooks
Feb 4, 2026
Merged
refactor(react-button): streamline button component base hook and remove unused base hooks #35689
Hotell
merged 4 commits into
microsoft:master
from
dmytrokirpa:refactor/button-state-hooks
Feb 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b258b1 to
28d31f8
Compare
28d31f8 to
18ee655
Compare
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
18ee655 to
21ca0b7
Compare
…ove unused base hooks
21ca0b7 to
02eb71c
Compare
Hotell
reviewed
Jan 23, 2026
change/@fluentui-react-button-e83c949c-d849-4636-b94e-c16be2c6079b.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-button/library/etc/react-button.api.md
Outdated
Show resolved
Hide resolved
…079b.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
Hotell
approved these changes
Jan 23, 2026
Contributor
Hotell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
krasnoff
pushed a commit
to krasnoff/fluentui
that referenced
this pull request
Feb 5, 2026
…ove unused base hooks (microsoft#35689) Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Previous Behavior
navTypeinCarouselButton) were inadvertently forwarded to the DOM after removinggetIntrinsicElementPropsNew Behavior
Removed unnecessary base hooks:
Consolidated base hooks for consistency:
Fixed custom props forwarding:
Related Issue(s)