-
Notifications
You must be signed in to change notification settings - Fork 170
Pre RN 0.81 changes: jsx-runtime, build updates, tool updates, package.json linting and normalization #3987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Running align-deps per package is significantly slower than once at the root level. Can we make it a prebuild step or similar? |
We discussed this offline today but I'll move this to API based invocation as a separate PR. The issue is the node startup cost. |
Dewsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge change - thank you very much for this timely migration.
Platforms Impacted
Description of changes
These changes help prepare FURN to go to RN 0.81, the next version that office will use.
Runtime Changes
Moved from using the classic runtime to the new react-jsx runtime. The classic runtime is no longer supported in react 19+ which will be a requirement for 0.81. The implementation was already in place but switching over required the following changes:
"jsx": "react-jsx"which causes the default behavior to be react's jsx-runtime.@jsxRuntime classicand@jsx withSlotscalls, replacing them with@jsxImportSource @fluentui-react-native/framework-baseBuild Changes
The main build change is to add a lint-package command for each package which allows us to reconfigure package.json files from the root without needing to make a ton of manual changes. The summary of build changes are:
There's probably more I'm forgetting. My apologies for the sheer number of changes but this should minimize the churn in the future.
Verification
Pipeline runs and tests