test(set): Improve set command E2E coverage #143
+7,157
−2,124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may-hartov
requested review from
aliabufoul,
aviatco,
ayeshurun,
ohadedry and
shirasassoon
aliabufoul
reviewed
Jan 21, 2026
aliabufoul
previously approved these changes
Jan 21, 2026
ohadedry
reviewed
Jan 22, 2026
ohadedry
reviewed
Jan 22, 2026
...est_set_gateway_virtualnetwork_success[capacityId-00000000-0000-0000-0000-000000000000].yaml
Outdated
Show resolved
Hide resolved
ohadedry
reviewed
Jan 22, 2026
...est_commands/recordings/test_commands/test_set/test_set_sparkpool_success[name-newName].yaml
Show resolved
Hide resolved
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
aviatco
reviewed
Jan 22, 2026
ohadedry
reviewed
Jan 25, 2026
| if metadata_to_set == "displayName": | ||
| set(new_entity.full_path, query="displayName", input=entity.display_name) | ||
| elif metadata_to_set == "name": | ||
| set(new_entity.full_path, query="name", input=entity.display_name) |
Contributor
There was a problem hiding this comment.
if query is name, does input is entity.display_name?
Collaborator
Author
There was a problem hiding this comment.
Yes. EntitiyMetadata has the Fabric resource type suffix - some-name.Type while displayName doesnt have the suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and enhances the test suite for the
setcommand, focusing on improving code reuse, and increasing test coverage for gateway and spark pool metadata updates.Test Refactoring and Parameterization:
test_set_sparkpool_successandtest_set_gateway_virtualNetwork_successto use parameterized test cases, allowing multiple metadata fields and input values to be tested more efficiently. The tests now call a shared helper method (_test_set_metadata_success) for improved code reuse and maintainability. [1] [2]Gateway Metadata and Cache Handling:
numberOfMemberGateways,inactivityMinutesBeforeSleep,displayName) and a new test for updating thecapacityIdfield.upsert_gateway_to_cachefixture to mock gateway cache updates in relevant tests.