-
Notifications
You must be signed in to change notification settings - Fork 35
fix: job run command exits with status code 1 on failure. #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aviatco
merged 8 commits into
microsoft:main
from
aviatco:dev/aviatcohen/raiseErrorOnjobRunFailure
Jan 20, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
11980fb
fix: job run command exits with status code 1 on failure.
15d2187
fix tests
d8e3035
Merge branch 'main' into dev/aviatcohen/raiseErrorOnjobRunFailure
aviatco 429d1bf
recording tests
408ea6f
Merge branch 'main' into dev/aviatcohen/raiseErrorOnjobRunFailure
aviatco 937278b
add failing notebook data sample
f884ee6
Merge branch 'dev/aviatcohen/raiseErrorOnjobRunFailure' of https://gi…
92880bc
remove unit tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| kind: fixed | ||
| body: Fix the job run command so that it exits with status code 1 on failure. | ||
| time: 2026-01-12T14:35:53.325666256Z | ||
| custom: | ||
| Author: aviatco | ||
| AuthorLink: https://github.com/aviatco |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
tests/test_commands/data/sample_items/example_failed.Notebook/.platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/fabric/gitIntegration/platformProperties/2.0.0/schema.json", | ||
| "metadata": { | ||
| "type": "Notebook", | ||
| "displayName": "example_failed", | ||
| "description": "Created by fab - designed to fail for testing" | ||
| }, | ||
| "config": { | ||
| "version": "2.0", | ||
| "logicalId": "00000000-0000-0000-0000-000000000000" | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
tests/test_commands/data/sample_items/example_failed.Notebook/notebook-content.ipynb
aviatco marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": { | ||
| "microsoft": { | ||
| "language": "python", | ||
| "language_group": "synapse_pyspark" | ||
| } | ||
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# This notebook is designed to fail for testing purposes\n", | ||
| "import sys\n", | ||
| "from time import sleep\n", | ||
| "\n", | ||
| "print('Starting notebook execution...')\n", | ||
| "sleep(2)\n", | ||
| "\n", | ||
| "# Intentionally cause a failure\n", | ||
| "raise Exception('Intentional failure for testing job failure scenarios')\n", | ||
| "\n", | ||
| "# This code should never be reached\n", | ||
| "print('This should never execute')" | ||
| ] | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "dependencies": {}, | ||
| "kernel_info": { | ||
| "name": "synapse_pyspark" | ||
| }, | ||
| "kernelspec": { | ||
| "display_name": "synapse_pyspark", | ||
| "name": "synapse_pyspark" | ||
| }, | ||
| "language_info": { | ||
| "name": "python" | ||
| }, | ||
| "microsoft": { | ||
| "language": "python", | ||
| "language_group": "synapse_pyspark", | ||
| "ms_spell_check": { | ||
| "ms_spell_check_language": "en" | ||
| } | ||
| }, | ||
| "nteract": { | ||
| "version": "nteract-front-end@1.0.0" | ||
| }, | ||
| "spark_compute": { | ||
| "compute_id": "/trident/default", | ||
| "session_options": { | ||
| "conf": { | ||
| "spark.synapse.nbs.session.timeout": "1200000" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "nbformat": 4, | ||
| "nbformat_minor": 5 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.