-
Notifications
You must be signed in to change notification settings - Fork 53
Changing the default dedupe statuses behavior #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR changes the default behavior for orchestration ID reuse policies to allow all orchestration statuses to be reusable, rather than just terminal statuses. This is a breaking change that assumes server-side implementations will terminate existing orchestrations in non-terminal states before creating new ones with the same instance ID.
Changes:
- Renamed
GetTerminalStatuses()toGetAllStatuses()and expanded it to include non-terminal statuses (Pending, Running, Suspended) - Modified
ConvertDedupeStatusesToReusePolicy()to return non-nullable policy and work with all statuses instead of just terminal ones - Updated all unit tests to reflect the new behavior and removed tests that validated non-terminal status filtering
- Updated comments in server-side code to reflect the new semantics
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/Client/Grpc/ProtoUtils.cs | Renamed method to GetAllStatuses, added non-terminal statuses, changed return type to non-nullable, updated logic to handle all statuses |
| src/Client/Grpc/GrpcDurableTaskClient.cs | Refactored dedupe status handling using collection expressions, removed conditional policy assignment logic |
| src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs | Updated comment to reflect "all statuses" instead of "terminal statuses" |
| test/Client/Grpc.Tests/ProtoUtilsTests.cs | Comprehensive test updates including renamed tests, updated assertions for all statuses, removed non-terminal filtering tests, added tests for new statuses |
Summary
Currently, only terminal statuses are reusable when creating a new orchestration with a given instance ID. This is enforced when creating the
OrchestrationIdReusePolicy, which ensures that only terminal statuses are considered "reusable" (minus whatever statuses the user includes in the dedupe statuses passed to the creation call). This PR allows all statuses to be reusable, with the assumption that the server-side implementation will terminate an existing orchestration if it is running, pending, or suspended (in a non-terminal status) before creating a new one. This is a breaking change for which all server-side implementations will need to be updated accordingly:Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Notes for reviewers