Dev #174
Merged
Dev #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new optional parameter for specifying the MySQL server port, defaulting to 3306. Updates connection instructions to include port information for both local and remote connections. Enhances clarity in troubleshooting steps for testing connections with the specified port.
Adds support for MySQL port configuration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds slot-based model assignment functionality to the state and UI, and introduces MySQL port support in the Python data loader.
- Define
ModelSlotsand related actions/selectors indfSlicefor 'generation' and 'hint' slots. - Update
ModelSelectionDialog.tsxto allow assigning models to slots with a new summary component and refined table UI. - Add
portparameter to MySQL loader, update connection instructions, and bump the project version.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/dfSlice.tsx | Added ModelSlotType/ModelSlots, updated reducers, actions, and selectors for slots. |
| src/views/ModelSelectionDialog.tsx | Revamped dialog UI to support slot assignments, including SlotAssignmentSummary. |
| pyproject.toml | Bumped package version from 0.2.1.4 to 0.2.1.5. |
| py-src/data_formulator/data_loader/mysql_data_loader.py | Introduced optional port parameter and updated auth instructions accordingly. |
Comments suppressed due to low confidence (2)
src/app/dfSlice.tsx:791
- [nitpick] The selector 'getActiveModel' specifically returns the 'generation' slot model; consider renaming it to 'getGenerationModel' for clarity.
getActiveModel: (state: DataFormulatorState) : ModelConfig => {
src/app/dfSlice.tsx:50
- Consider adding unit tests for the new ModelSlots reducer logic and getModelBySlot selector to verify correct slot assignments.
export interface ModelSlots {
| self.duck_db_conn.install_extension("mysql") | ||
| self.duck_db_conn.load_extension("mysql") | ||
|
|
||
| attatch_string = "" |
There was a problem hiding this comment.
Variable name 'attatch_string' is misspelled; consider renaming to 'attach_string' for clarity.
| const noBorderStyle = ['error'].includes(status) ? 'none' : undefined; | ||
|
|
||
| // Check if model is assigned to any slot | ||
| const isAssignedToAnySlot = dfSelectors.getAllSlotTypes().some(slotType => isModelAssignedToSlot(model.id, slotType)); |
There was a problem hiding this comment.
[nitpick] Refactoring opportunity: call dfSelectors.getAllSlotTypes() once into a local variable to avoid repeated selector calls and improve readability.
Suggested change
| const isAssignedToAnySlot = dfSelectors.getAllSlotTypes().some(slotType => isModelAssignedToSlot(model.id, slotType)); | |
| const isAssignedToAnySlot = allSlotTypes.some(slotType => isModelAssignedToSlot(model.id, slotType)); |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update with mysql port support