Skip to content

Minor fix to the query that should not alter prior semantics. Previou… #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 1 commit into from
Dec 18, 2025
Merged

Minor fix to the query that should not alter prior semantics. Previou… #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cpp/ql/src/Microsoft/Likely Bugs/SizeOfMisuse/ArgumentIsSizeofOrOperation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ predicate isIgnorableBinaryOperation(BinaryOperation op) {
zeroOperand.getExplicitlyConverted().getUnspecifiedType() = t and
// often 'NULL' is defined as (void *)0, ignore these cases
not t instanceof VoidPointerType and
(
// Apparently derived types, eg., functoin pointers, aren't PointerType
// according to codeql, so special casing them out here.
other.getUnspecifiedType() instanceof DerivedType
or
other.getUnspecifiedType() instanceof PointerType
)
// Note Function pointers are not considered PointerType
// casting a wider net here and saying the 'other' cannot be a
// derived type, which is probably too wide, but I think anything
//loosely matching this pattern should be ignored.
other.getUnspecifiedType() instanceof DerivedType
)
}

Expand Down