fix(zbar): drop GIR typelib/gir file listings from %files sections#15972
Open
dmcilvaney wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
Open
fix(zbar): drop GIR typelib/gir file listings from %files sections#15972dmcilvaney wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
dmcilvaney wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the zbar package by removing GObject Introspection (GIR) file listings from the spec's %files sections. Since GLib 2.80, g-ir-scanner was merged into glib2 but ships separately in gobject-introspection. The zbar spec never explicitly BuildRequires it, so typelib/gir files are no longer generated. This aligns with the upstream Fedora fix in rawhide.
Changes:
- Move zbar from inline definition in components-full.toml to dedicated component file
- Add four spec-search-replace overlays to remove typelib and .gir file listings from %files sections
- Include comprehensive explanatory comments and upstream reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/zbar/zbar.comp.toml | New dedicated component file with overlays to remove GIR-related file listings that would cause FTBFS |
| base/comps/components-full.toml | Remove inline zbar entry (moved to dedicated file) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The zbar f43 spec lists ZBar-1.0.typelib and ZBar-1.0.gir in the zbar-gtk and zbar-gtk-devel subpackages, but those files are only generated when g-ir-scanner is present at build time. Since GLib 2.80, GObject Introspection tools were merged into the glib2 source tree, but the legacy g-ir-scanner binary still ships in the separate gobject-introspection package. The zbar spec never explicitly BuildRequires it — it only worked by accident via transitive deps that no longer pull it in. Fedora hit the same FTBFS and removed the GIR file listings in rawhide: https://src.fedoraproject.org/rpms/zbar/c/a1e97927fd862a8ca777462155b54c4ee4176923 Apply four spec-search-replace overlays to remove the four affected lines, aligning with the upstream fix. Tested: built locally, zbar-gtk RPM no longer lists typelib, zbar-gtk-devel no longer lists .gir, zbarimg --version works in mock.
dmcilvaney
force-pushed
the
damcilva/4.0/pkg_fixes/zbar
branch
from
6d790f8 to
dfc1df2
Compare
reubeno
reviewed
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zbar f43 spec lists ZBar-1.0.typelib and ZBar-1.0.gir in the zbar-gtk and zbar-gtk-devel subpackages, but those files are only generated when g-ir-scanner is present at build time. Since GLib 2.80, GObject Introspection tools were merged into the glib2 source tree, but the legacy g-ir-scanner binary still ships in the separate gobject-introspection package. The zbar spec never explicitly BuildRequires it — it only worked by accident via transitive deps that no longer pull it in.
Fedora hit the same FTBFS and removed the GIR file listings in rawhide: https://src.fedoraproject.org/rpms/zbar/c/a1e97927fd862a8ca777462155b54c4ee4176923
Apply four spec-search-replace overlays to remove the four affected lines, aligning with the upstream fix.
Tested: built locally, zbar-gtk RPM no longer lists typelib, zbar-gtk-devel no longer lists .gir, zbarimg --version works in mock.