Skip to content

Conversation

@archana25-ms
Copy link
Contributor

@archana25-ms archana25-ms commented Dec 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch glib for CVE-2024-34397

CVE-2024-24397 was merged in PR-14223 and was later reverted back in PR-14745 since there was test failure in ModemManager package during full build because of the CVE fix.

Hence in this PR the CVE patch is backported from https://gitlab.gnome.org/GNOME/glib/-/issues/3268#fixes
and verified the test execution of ModemManager package with the fixed glib present in toolchain.

Change Log
  • added: SPECS/glib/CVE-2024-34397.patch
  • modified: SPECS/glib/glib.spec
  • modified: toolkit/resources/manifests/package/pkggen_core_aarch64.txt
  • modified: toolkit/resources/manifests/package/pkggen_core_x86_64.txt
  • modified: toolkit/resources/manifests/package/toolchain_aarch64.txt
  • modified: toolkit/resources/manifests/package/toolchain_x86_64.txt
Does this affect the toolchain?

YES

Associated issues
Links to CVEs
Test Methodology

Patch applies cleanly

image

Build is Successful

image

Verified ModemManager test with patched glib and its passed

image

@archana25-ms archana25-ms requested a review from a team as a code owner December 22, 2025 11:45
@archana25-ms archana25-ms marked this pull request as draft December 22, 2025 11:51
@archana25-ms archana25-ms marked this pull request as ready for review December 22, 2025 12:13
@Kanishk-Bansal
Copy link
Contributor

Buddy Build

@archana25-ms
Copy link
Contributor Author

Buddy Build

Buddy build is successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants