-
Notifications
You must be signed in to change notification settings - Fork 602
[AutoPR- Security] Patch coredns for CVE-2025-68156 [HIGH] #15349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR- Security] Patch coredns for CVE-2025-68156 [HIGH] #15349
Conversation
|
AI backport was good. In the vendor file |
|
/azurepipeline run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akhila-guruju and @Kanishk-Bansal I see that this patch originated from the upstream, but this is a terrible solution. Limiting regression to a depth to10000 mitigates, but it really isn't a solution because what to prevent the stack from blowing out at a depth of 5000 or 1000? I think we should work with MSRC or maybe the upstream on this. Golang should cause a stack overflow panic which will terminate the recursion. Maybe this exception should be caught instead and then have that returned as an error? |
jslobodzian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix seems a little underdeveloped to me. It IS a mitigation, but not a solution.
| Names []string | ||
| + | ||
| + // MaxDepth limits the recursion depth for nested structures. | ||
| + MaxDepth = 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does coredns need to change to set this to a smaller value?
Co-authored-by: Kanishk Bansal <103916909+Kanishk-Bansal@users.noreply.github.com> Co-authored-by: jslobodzian <joslobo@microsoft.com> (cherry picked from commit 30125d5)
|
Auto cherry-pick results:
Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1012833&view=results |
Auto Patch coredns for CVE-2025-68156.
Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1008162&view=results
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology