Skip to content

Fix for javacc build issue #15337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aninda-al wants to merge 3 commits into
base: 3.0-dev
Choose a base branch
from
Open

Fix for javacc build issue #15337

aninda-al wants to merge 3 commits into from

Conversation

@aninda-al
Copy link
Contributor

@aninda-al aninda-al commented Dec 18, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?
Fixes javacc build issue by setting javac to use version 1.8
Fixes license warning for javacc and apache-commons-jexl

Change Log
  • modified: SPECS-EXTENDED/javacc/javacc.spec
  • modified: SPECS-EXTENDED/apache-commons-jexl/apache-commons-jexl.spec
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • local build
image

apache-commons-jexl-2.1.1-3.azl3.src.rpm.log
javacc-7.0.4-4.azl3.src.rpm.log

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 18, 2025
@aninda-al aninda-al force-pushed the fix-javacc-build-issue branch from 450743b to 1e7aefa Compare December 18, 2025 03:42
@aninda-al aninda-al marked this pull request as ready for review December 18, 2025 04:09
@aninda-al aninda-al requested a review from a team as a code owner December 18, 2025 04:09
@aninda-al aninda-al force-pushed the fix-javacc-build-issue branch from 1e7aefa to a4b791e Compare December 19, 2025 03:07
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 21, 2025 •
edited
Loading

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1009708&view=results

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 21, 2025

There are license check failures

##[warning]License issues found.
WARN: (apache-commons-jexl-2.1.1-3.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/doc/apache-commons-jexl/NOTICE.txt
WARN: (apache-commons-jexl-javadoc-2.1.1-3.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/doc/apache-commons-jexl-javadoc/NOTICE.txt
/usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/ADDITIONAL_LICENSE_INFO
/usr/share/javadoc/apache-commons-jexl/legal/ADDITIONAL_LICENSE_INFO
duplicated license files:
/usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/LICENSE
/usr/share/javadoc/apache-commons-jexl/legal/LICENSE
WARN: (javacc-javadoc-7.0.4-4.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/javadoc/javacc/legal/ADDITIONAL_LICENSE_INFO
duplicated license files:
/usr/share/javadoc/javacc/legal/LICENSE

@aninda-al
Copy link
Contributor Author

aninda-al commented Dec 22, 2025

There are license check failures

##[warning]License issues found. WARN: (apache-commons-jexl-2.1.1-3.azl3.noarch.rpm) has license warnings: bad %doc files: /usr/share/doc/apache-commons-jexl/NOTICE.txt WARN: (apache-commons-jexl-javadoc-2.1.1-3.azl3.noarch.rpm) has license warnings: bad %doc files: /usr/share/doc/apache-commons-jexl-javadoc/NOTICE.txt /usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/ADDITIONAL_LICENSE_INFO /usr/share/javadoc/apache-commons-jexl/legal/ADDITIONAL_LICENSE_INFO duplicated license files: /usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/LICENSE /usr/share/javadoc/apache-commons-jexl/legal/LICENSE WARN: (javacc-javadoc-7.0.4-4.azl3.noarch.rpm) has license warnings: bad %doc files: /usr/share/javadoc/javacc/legal/ADDITIONAL_LICENSE_INFO duplicated license files: /usr/share/javadoc/javacc/legal/LICENSE

@sandeepkarambelkar I believe I fixed the issue, could you please trigger another buddy build? Thanks!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010948&view=results

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

License warnings still exist -

##[warning]License issues found.
WARN: (apache-commons-jexl-javadoc-2.1.1-4.azl3.noarch.rpm) has license warnings:
duplicated license files:
/usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/ADDITIONAL_LICENSE_INFO
/usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/LICENSE
/usr/share/javadoc/apache-commons-jexl/legal/ADDITIONAL_LICENSE_INFO
/usr/share/javadoc/apache-commons-jexl/legal/LICENSE
WARN: (javacc-javadoc-7.0.4-4.azl3.noarch.rpm) has license warnings:
duplicated license files:
/usr/share/javadoc/javacc/legal/ADDITIONAL_LICENSE_INFO
/usr/share/javadoc/javacc/legal/LICENSE

@aninda-al
Copy link
Contributor Author

aninda-al commented Dec 24, 2025

License warnings still exist -

##[warning]License issues found. WARN: (apache-commons-jexl-javadoc-2.1.1-4.azl3.noarch.rpm) has license warnings: duplicated license files: /usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/ADDITIONAL_LICENSE_INFO /usr/share/javadoc/apache-commons-jexl/jexl2-compat/legal/LICENSE /usr/share/javadoc/apache-commons-jexl/legal/ADDITIONAL_LICENSE_INFO /usr/share/javadoc/apache-commons-jexl/legal/LICENSE WARN: (javacc-javadoc-7.0.4-4.azl3.noarch.rpm) has license warnings: duplicated license files: /usr/share/javadoc/javacc/legal/ADDITIONAL_LICENSE_INFO /usr/share/javadoc/javacc/legal/LICENSE

@sandeepkarambelkar I made some additional changes for the license issue and verified locally that the problems are resolved. Could you please trigger another buddybuild? Thanks!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 24, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011961&view=results

@aninda-al
Copy link
Contributor Author

aninda-al commented Dec 24, 2025 •
edited
Loading

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011961&view=results

@sandeepkarambelkar BuddyBuild result looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aninda-al @sandeepkarambelkar