-
Notifications
You must be signed in to change notification settings - Fork 103
Delete recordings infrastructure with related tests #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Delete recordings infrastructure with related tests #716
Conversation
| qiskit-ionq helpers and exceptions (commit cea8f9874b992f82a35648582c06958869370c69) - Apache-2.0 | ||
|
|
||
| Portions of azure.quantum.qiskit.backends._qiskit_ionq.py and azure-quantum/tests/unit/test_qiskit.py | ||
| Portions of azure.quantum.qiskit.backends._qiskit_ionq.py and azure-quantum/tests/unit/local/test_qiskit_offline.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScottCarda-MS could you please have a look if we need to include test_qiskit_offline here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I don't think so. The live test files were quite large so it is difficult to tell what parts of them came from the community repo, but the test_qiskit_offline tests are considerably simpler than the live tests, so I don't think they are conceptually related to community content.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Delete recordings infrastracture and all related tests as part of recordings removal effort.
We can delete these tests because in earlier PRs:
unit/localfolder.toxnow runs againstunit/local/test_qiskit_offline.py