Skip to content

.NET: Fix AddWorkflow default lifetime to Transient for concurrent runs #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Greal-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

.NET: Fix AddWorkflow default lifetime to Transient for concurrent runs #4813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Microsoft.Agents.AI.Hosting/HostApplicationBuilderWorkflowExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static class HostApplicationBuilderWorkflowExtensions
/// <exception cref="InvalidOperationException">
/// Thrown when the factory delegate returns null or a workflow with a name that doesn't match the expected name.
/// </exception>
public static IHostedWorkflowBuilder AddWorkflow(this IHostApplicationBuilder builder, string name, Func<IServiceProvider, string, Workflow> createWorkflowDelegate, ServiceLifetime lifetime = ServiceLifetime.Singleton)
public static IHostedWorkflowBuilder AddWorkflow(this IHostApplicationBuilder builder, string name, Func<IServiceProvider, string, Workflow> createWorkflowDelegate, ServiceLifetime lifetime = ServiceLifetime.Transient)
{
Throw.IfNull(builder);
Throw.IfNull(name);
Expand Down
6 changes: 3 additions & 3 deletions ...ts/Microsoft.Agents.AI.Hosting.UnitTests/HostApplicationBuilderWorkflowExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ public void AddWorkflow_ValidParameters_ReturnsBuilder()
}

/// <summary>
/// Verifies that AddWorkflow registers the workflow as a keyed singleton service by default.
/// Verifies that AddWorkflow registers the workflow as a keyed transient service by default.
/// </summary>
[Fact]
public void AddWorkflow_RegistersKeyedSingleton()
public void AddWorkflow_RegistersKeyedTransient()
{
var builder = new HostApplicationBuilder();
const string WorkflowName = "testWorkflow";
Expand All @@ -78,7 +78,7 @@ public void AddWorkflow_RegistersKeyedSingleton()
d.ServiceType == typeof(Workflow));

Assert.NotNull(descriptor);
Assert.Equal(ServiceLifetime.Singleton, descriptor.Lifetime);
Assert.Equal(ServiceLifetime.Transient, descriptor.Lifetime);
}

/// <summary>
Expand Down