Python: fix(core): workflow cancellation not propagating to active executors#3663
Merged
markwallace-microsoft merged 2 commits intomicrosoft:mainfrom Feb 4, 2026
Merged
Python: fix(core): workflow cancellation not propagating to active executors#3663markwallace-microsoft merged 2 commits intomicrosoft:mainfrom
markwallace-microsoft merged 2 commits intomicrosoft:mainfrom
Conversation
dmytrostruk
approved these changes
Feb 4, 2026
Member
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where workflow cancellation was not properly propagating to active executors. When a workflow was cancelled during the execution of the second or subsequent executor, the active executor would continue running to completion instead of being cancelled.
Changes:
- Added cancellation handling in the workflow runner's polling loop to cancel orphaned iteration tasks
- Added comprehensive test coverage for workflow cancellation behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/packages/core/agent_framework/_workflows/_runner.py | Added try-except block to catch CancelledError in polling loop, cancel iteration_task, and properly clean it up before re-raising |
| python/packages/core/tests/workflow/test_runner.py | Added SlowExecutor test helper class and test_runner_cancellation_stops_active_executor test to verify cancellation propagates correctly |
markwallace-microsoft
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When a workflow is cancelled via
asyncio.create_task()+task.cancel(), executors that are mid-execution continue running to completion instead of being cancelled. This only affects executors after the first one (Step2+), because theCancelledErroris raised in the polling loop but theiteration_taskcreated viaasyncio.create_task()is orphaned and keeps running.Description
Contribution Checklist