Skip to content

Python: Fix observability module mypy error #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TaoChenOSU merged 1 commit into from
Dec 4, 2025
Merged

Python: Fix observability module mypy error #2641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions python/packages/core/agent_framework/observability.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

if TYPE_CHECKING: # pragma: no cover
from azure.core.credentials import TokenCredential
from opentelemetry.sdk._logs._internal.export import LogRecordExporter
from opentelemetry.sdk._logs.export import LogRecordExporter
from opentelemetry.sdk.metrics.export import MetricExporter
from opentelemetry.sdk.resources import Resource
from opentelemetry.sdk.trace.export import SpanExporter
Expand Down Expand Up @@ -268,9 +268,9 @@ def _get_otlp_exporters(endpoints: list[str]) -> list["LogRecordExporter | SpanE
exporters: list["LogRecordExporter | SpanExporter | MetricExporter"] = []

for endpoint in endpoints:
exporters.append(OTLPLogExporter(endpoint=endpoint)) # type: ignore[arg-type]
exporters.append(OTLPSpanExporter(endpoint=endpoint)) # type: ignore[arg-type]
exporters.append(OTLPMetricExporter(endpoint=endpoint)) # type: ignore[arg-type]
exporters.append(OTLPLogExporter(endpoint=endpoint))
exporters.append(OTLPSpanExporter(endpoint=endpoint))
exporters.append(OTLPMetricExporter(endpoint=endpoint))
return exporters


Expand Down Expand Up @@ -493,8 +493,7 @@ def _configure_providers(self, exporters: list["LogRecordExporter | MetricExport
"""Configure tracing, logging, events and metrics with the provided exporters."""
from opentelemetry._logs import set_logger_provider
from opentelemetry.sdk._logs import LoggerProvider, LoggingHandler
from opentelemetry.sdk._logs._internal.export import LogRecordExporter
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor, LogRecordExporter
from opentelemetry.sdk.metrics import MeterProvider
from opentelemetry.sdk.metrics.export import MetricExporter, PeriodicExportingMetricReader
from opentelemetry.sdk.metrics.view import DropAggregation, View
Expand Down Expand Up @@ -522,7 +521,7 @@ def _configure_providers(self, exporters: list["LogRecordExporter | MetricExport
logger_provider.add_log_record_processor(BatchLogRecordProcessor(exporter))
should_add_console_exporter = False
if should_add_console_exporter:
from opentelemetry.sdk._logs._internal.export import ConsoleLogExporter
from opentelemetry.sdk._logs.export import ConsoleLogExporter

logger_provider.add_log_record_processor(BatchLogRecordProcessor(ConsoleLogExporter()))

Expand Down
Loading