Python: [BREAKING] Removed default "store" value#2443
Merged
dmytrostruk merged 5 commits intomicrosoft:mainfrom Nov 25, 2025
Merged
Python: [BREAKING] Removed default "store" value#2443dmytrostruk merged 5 commits intomicrosoft:mainfrom
dmytrostruk merged 5 commits intomicrosoft:mainfrom
Conversation
Member
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a breaking change that removes the default store=False value from the OpenAI Responses client implementation, allowing the code to rely on the server's default value of True instead.
Key Changes
- Removed automatic setting of
store=Falsewhen the parameter is not specified - Updated logic in
get_conversation_idmethods to properly handleNoneas "use server default" - Removed validation that automatically set
store=Truewhenconversation_idwas provided - Updated sample code to explicitly set
store=Falsewhere needed to maintain previous behavior - Updated tests to verify that
storeis omitted from options when set toNone
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
python/packages/core/agent_framework/openai/_responses_client.py |
Updated get_conversation_id to return conversation ID when store is None; removed default store=False from prepare_options; refactored conversation ID assignment logic |
python/packages/core/agent_framework/_clients.py |
Removed validation logic that forced store=True when conversation_id was set |
python/packages/azure-ai/agent_framework_azure_ai/_client.py |
Removed default store value setting in prepare_options; updated get_conversation_id to handle None as server default |
python/packages/core/tests/openai/test_openai_responses_client.py |
Updated test assertions to verify store is not included in options when set to None |
python/samples/getting_started/agents/openai/openai_responses_client_with_thread.py |
Added explicit store=False to in-memory example; removed explicit store=True and related comment from server-side storage example |
eavanvalkenburg
approved these changes
Nov 25, 2025
giles17
approved these changes
Nov 25, 2025
giles17
approved these changes
Nov 25, 2025
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
* Removed default store value * Small fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Removed default value of
storeparameter to rely on server's default value in OpenAI Responses client.Important
This is a breaking change. Currently, the default value of
storeparameter in OpenAI Responses client implementation isFalse. With this PR, the default value is removed from the codebase to rely on server's default value, which isTrue. To revert the logic back toFalse, setstore=Falseexplicitly inrun/run_streammethods forChatAgentandget_response/get_streaming_responseforBaseChatClient.Contribution Checklist