Python: small fix for logging in declarative#2341
Merged
eavanvalkenburg merged 2 commits intomicrosoft:mainfrom Nov 20, 2025
Merged
Python: small fix for logging in declarative#2341eavanvalkenburg merged 2 commits intomicrosoft:mainfrom
eavanvalkenburg merged 2 commits intomicrosoft:mainfrom
Conversation
Member
Python Test Coverage Report •
Python Unit Test Overview
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a logging improvement for the declarative loader in Python, specifically addressing security concerns when logging API keys. The change adds a log_value parameter to the _try_powerfx_eval function to control whether sensitive values are fully logged.
Key changes:
- Added a
log_valueparameter to_try_powerfx_evalto control logging verbosity for sensitive values - Modified exception logging to show only the first 5 characters of values when
log_value=False - Updated the warning message for unavailable PowerFx engine to be more generic
python/packages/declarative/agent_framework_declarative/_models.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_models.py
Outdated
Show resolved
Hide resolved
moonbox3
approved these changes
Nov 20, 2025
javiercn
approved these changes
Nov 20, 2025
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
* small fix for logging in declarative * fix spaces in string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Small fix for the logs being produced by the declarative loader
Description
Contribution Checklist