Python: fix Langfuse observability to capture ChatAgent system instru…#2316
Merged
eavanvalkenburg merged 1 commit intomicrosoft:mainfrom Nov 19, 2025
Merged
Conversation
…ctions Fix bug where ChatAgent system instructions were not captured in Langfuse traces due to incorrect attribute access. The observability code was attempting to retrieve instructions using getattr(self, "instructions", None), but ChatAgent stores instructions in self.chat_options.instructions. This caused system_instructions to always be None in Langfuse traces. Changed both _trace_agent_run and _trace_agent_run_stream functions to correctly retrieve instructions from chat_options.instructions. Fixes affect: - Line 1123: _trace_agent_run (non-streaming) - Line 1192: _trace_agent_run_stream (streaming)
eavanvalkenburg
approved these changes
Nov 19, 2025
Member
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
moonbox3
approved these changes
Nov 19, 2025
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
…ctions (microsoft#2316) Fix bug where ChatAgent system instructions were not captured in Langfuse traces due to incorrect attribute access. The observability code was attempting to retrieve instructions using getattr(self, "instructions", None), but ChatAgent stores instructions in self.chat_options.instructions. This caused system_instructions to always be None in Langfuse traces. Changed both _trace_agent_run and _trace_agent_run_stream functions to correctly retrieve instructions from chat_options.instructions. Fixes affect: - Line 1123: _trace_agent_run (non-streaming) - Line 1192: _trace_agent_run_stream (streaming)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ctions
Fix bug where ChatAgent system instructions were not captured in Langfuse traces due to incorrect attribute access.
The observability code was attempting to retrieve instructions using getattr(self, "instructions", None), but ChatAgent stores instructions in self.chat_options.instructions. This caused system_instructions to always be None in Langfuse traces.
Changed both _trace_agent_run and _trace_agent_run_stream functions to correctly retrieve instructions from chat_options.instructions.
Fixes affect:
Motivation and Context
Description
Contribution Checklist