Python: added test to validate status set#2265
Merged
eavanvalkenburg merged 1 commit intomicrosoft:mainfrom Nov 19, 2025
Merged
Python: added test to validate status set#2265eavanvalkenburg merged 1 commit intomicrosoft:mainfrom
eavanvalkenburg merged 1 commit intomicrosoft:mainfrom
Conversation
Member
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a complex mock-based test for exception handling with a simpler, more focused test that validates error status setting for function execution telemetry. The new test directly tests the ai_function decorator's error handling capabilities rather than mocking internal observability components.
Key Changes
- Removed unused imports (
MagicMock,patch) that were only used in the old test - Added
ai_functionimport to support the new test - Replaced
test_agent_run_with_exception_handlingwithtest_function_call_with_error_handlingthat tests actual function execution errors
moonbox3
approved these changes
Nov 17, 2025
dmytrostruk
approved these changes
Nov 19, 2025
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds a test to validate that status is set to error for a execute_tool span.
Closes: #2217
Description
Contribution Checklist