Skip to content

Forgot to implement the WASDK API for operations related to PackageVolume? #5485 #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrusTheAxe wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Forgot to implement the WASDK API for operations related to PackageVolume? #5485 #6104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7df7950
Remaining PackageVolume operations
DrusTheAxe Jul 28, 2025
1c31e13
Partial implementation
DrusTheAxe Aug 7, 2025
3d0fd42
Merge branch 'main' into user/drustheaxe/packagevolume-v2
DrusTheAxe Oct 6, 2025
588971e
Fixed PackageVolume. Added start of tests
DrusTheAxe Oct 6, 2025
dfec617
Fixed build break
DrusTheAxe Oct 6, 2025
462a115
Fixed build errors. Added PackageVolume test to .testdef
DrusTheAxe Oct 6, 2025
3ed8083
Merge branch 'main' into user/drustheaxe/packagevolume-v2
DrusTheAxe Oct 18, 2025
e70f88b
Forgot to implement the WASDK API for operations related to PackageVo…
DrusTheAxe Dec 24, 2025
884d98d
Fixed Progress reporting for *Async() - was Status=Queued and raw uin…
DrusTheAxe Dec 24, 2025
ca4d4d4
Fixed some doc-comments
DrusTheAxe Dec 24, 2025
7f6d0cf
Merge branch 'main' into user/drustheaxe/packagevolume-v2
DrusTheAxe Dec 24, 2025
ef6d8a8
Updated .idl (corrected syntax typos/bugs, updated doc-comments)
DrusTheAxe Dec 24, 2025
aed51e8
Fixed bad merge
DrusTheAxe Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions WindowsAppRuntime.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,9 @@ EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Decimal", "Decimal", "{5012149E-F09F-4F18-A03C-FFE597203821}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Windows.Foundation.Projection", "dev\Projections\CS\Microsoft.Windows.Foundation\Microsoft.Windows.Foundation.Projection.csproj", "{8EBA8758-19D5-AE31-FD9C-86BBA3BFF6CA}"
ProjectSection(ProjectDependencies) = postProject
{B73AD907-6164-4294-88FB-F3C9C10DA1F1} = {B73AD907-6164-4294-88FB-F3C9C10DA1F1}
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "CPP", "CPP", "{7C0F3E70-BDB3-40B2-84E1-B1B77A80CB53}"
EndProject
Expand Down
10 changes: 5 additions & 5 deletions dev/Interop/StoragePickers/PickerCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ namespace PickerCommon {
return;
}

for (int i = 0; i < value.size(); i++)
for (size_t i = 0; i < value.size(); i++)
{
if (value[i] == L'\0')
{
Expand All @@ -203,7 +203,7 @@ namespace PickerCommon {
PickerLocalization::GetStoragePickersLocalizationText(ImproperFileExtensionLocalizationKey));
}

for (int i = 1; i < filter.size(); i++)
for (size_t i = 1; i < filter.size(); i++)
{
if (filter[i] == L'.' || filter[i] == L'*' || filter[i] == L'?')
{
Expand Down Expand Up @@ -243,7 +243,7 @@ namespace PickerCommon {
}

// The method SHSimpleIDListFromPath does syntax check on the path string.
wil::unique_cotaskmem_ptr<ITEMIDLIST> pidl(SHSimpleIDListFromPath(path.c_str()));
wil::unique_cotaskmem_ptr<ITEMIDLIST> pidl{ SHSimpleIDListFromPath(path.c_str()) };
if (!pidl)
{
throw std::invalid_argument(propertyName);
Expand Down Expand Up @@ -428,11 +428,11 @@ namespace PickerCommon {

if (FileTypeFilterPara.size() > 0)
{
check_hresult(dialog->SetFileTypes((UINT)FileTypeFilterPara.size(), FileTypeFilterPara.data()));
check_hresult(dialog->SetFileTypes(static_cast<UINT>(FileTypeFilterPara.size()), FileTypeFilterPara.data()));

if (FocusLastFilter)
{
check_hresult(dialog->SetFileTypeIndex(FileTypeFilterPara.size()));
check_hresult(dialog->SetFileTypeIndex(static_cast<UINT>(FileTypeFilterPara.size())));
}
}
}
Expand Down
418 changes: 415 additions & 3 deletions dev/PackageManager/API/M.W.M.D.PackageVolume.cpp
View file
Open in desktop

Large diffs are not rendered by default.

35 changes: 32 additions & 3 deletions dev/PackageManager/API/M.W.M.D.PackageVolume.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,31 +9,60 @@ namespace winrt::Microsoft::Windows::Management::Deployment::implementation
{
struct PackageVolume : PackageVolumeT<PackageVolume>
{
PackageVolume() = delete;
PackageVolume() = default;
PackageVolume(winrt::Windows::Management::Deployment::PackageVolume const& value);

static bool IsFeatureSupported(winrt::Microsoft::Windows::Management::Deployment::PackageVolumeFeature feature);
static winrt::Windows::Foundation::Collections::IVector<winrt::Microsoft::Windows::Management::Deployment::PackageVolume> FindPackageVolumes();
static winrt::Microsoft::Windows::Management::Deployment::PackageVolume FindPackageVolumeByPath(hstring const& packageStorePath);
static winrt::Microsoft::Windows::Management::Deployment::PackageVolume GetPackageVolumeByPath(hstring const& path);
static winrt::Microsoft::Windows::Management::Deployment::PackageVolume FindPackageVolumeByName(hstring const& name);
static winrt::Microsoft::Windows::Management::Deployment::PackageVolume GetPackageVolumeByName(hstring const& name);
static winrt::Microsoft::Windows::Management::Deployment::PackageVolume GetDefault();
static winrt::Windows::Foundation::IAsyncOperation<winrt::Microsoft::Windows::Management::Deployment::PackageVolume> AddAsync(hstring packageStorePath);

bool IsSystemVolume();
hstring MountPoint();
hstring Name();
hstring PackageStorePath();
bool SupportsHardLinks();
bool IsFullTrustPackageSupported();
bool IsAppxInstallSupported();
bool IsFullTrustPackageSupported();
bool IsRepairNeeded();
void Repair();
bool IsOffline();
void SetDefault();
winrt::Windows::Foundation::IAsyncOperationWithProgress<winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentResult, winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress> RemoveAsync();
winrt::Windows::Foundation::IAsyncOperationWithProgress<winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentResult, winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress> SetOfflineAsync();
winrt::Windows::Foundation::IAsyncOperationWithProgress<winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentResult, winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress> SetOnlineAsync();
winrt::Windows::Foundation::IAsyncOperation<uint64_t> GetAvailableSpaceAsync();

private:
HRESULT Remove(
winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress& packageDeploymentProgress,
wistd::function<void(winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress)> progress,
HRESULT& extendedError,
winrt::hstring& errorText,
winrt::guid& activityId);

HRESULT SetOnline(
const bool online,
winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress& packageDeploymentProgress,
wistd::function<void(winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentProgress)> progress,
HRESULT& extendedError,
winrt::hstring& errorText,
winrt::guid& activityId);

private:
winrt::Windows::Management::Deployment::PackageVolume m_windowsPackageVolume{ nullptr };
bool m_isSystemVolume{};
hstring m_mountPoint;
hstring m_name;
hstring m_packageStorePath;
bool m_supportsHardLinks{};
bool m_isFullTrustPackageSupported{};
bool m_isAppxInstallSupported{};
bool m_isFullTrustPackageSupported{};
bool m_isOffline{};
};
}
namespace winrt::Microsoft::Windows::Management::Deployment::factory_implementation
Expand Down
Loading
Loading