-
Notifications
You must be signed in to change notification settings - Fork 408
Official API Review for new functionalities of Storage.Pickers: SettingsIdentifier; FileTypeIndex; Title; PickMultipleFoldersAsync; ShowOverwritePrompt; CreateNewFileIfNotExists #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DinahK-2SO
wants to merge
9
commits into
main
Choose a base branch
from
user/DinahK-2SO/spec_settingsidentifier_filetypefilterindex_title
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+258
−8
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
52e99ff
API Spec for SettingsIdentifier; FileTypeIndex; Title; FolderPicker.P…
DinahK-2SO 7af6a89
adding FileSavePicker.ShowOverwritePrompt and FileSavePicker.CreateNe…
DinahK-2SO b5de7c2
Add notes explaining the range of DefaultFileExtension
DinahK-2SO 0e6bf29
resolve comments
DinahK-2SO e4a3478
Merge branch 'user/DinahK-2SO/spec_settingsidentifier_filetypefilteri…
DinahK-2SO 474253b
add note for the FileType properties
DinahK-2SO 549597d
IReference<UInt32> DefaultFileTypeIndex
DinahK-2SO 929b1c3
fix 1u
DinahK-2SO 2ae5d38
update message to be more outstanding.
DinahK-2SO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreateNewFileIfNotExists = true by default means the picker may create files as a side effect of a UI operation?
Combined with ShowOverwritePrompt = false, this could lead to accidental data creation or replacement.
Whether true is the safest default here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Saharsh979 , thanks for raising up this topic!
CreateNewFileIfnotExists = trueis already the default behavior of FileSavePicker. This default behavior is consistent with that of the UWP FileSavePicker. Here we're making it customizable so that developers can choose to disable it.Please note the FileSavePicker should only create a new file when the picked file doesn't exists ( #6023 and #6024 ensured this check ). Therefore,
ShowOverwritePromptdoesn't conflict withCreateNewFileIfnotExistsin any combination, for the former takes effects when the picked file exists, and the latter works when the picked file doesn't exist.With the 2 properties, developers will have the flexibility in showing their own warning prompts. Kindly find more details here: #5976