DevCheck: Creating nuget directory if it does not exist

[guimafelipe]

If I don't have the nuget.exe directory created, running DevCheck.ps1 -NugetExeUpdate fails as the curl command cannot create the file in the download process (by default, if I don't have the .user directory).

This change makes the script create the directory in case of a first download of the nuget in the computer.

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

[Copilot]

Pull request overview

This PR fixes an issue where the DevCheck script fails when attempting to download nuget.exe if the target directory doesn't exist. The script now creates the necessary directory structure before downloading the file.

• Adds directory existence check before downloading nuget.exe
• Creates the directory if it doesn't exist to prevent curl download failures

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[DrusTheAxe]

I assume

[DrusTheAxe]

...\.user directory's created by DevCheck but could be a timing thing, or simply one tells DevCheck to only download nuget.exe and not do other things (which happen to create .user)

function Get-UserPath creates the .user directory but as $NugetExe could be anywhere (not just there) we have 2 choices

1. Create the target dir for the caller
2. Expect the target dir exists (caller's job to ensure it exists) AND ensure .user (and .temp) are created before doing any Nuget processing

I'm kinda partial to #2. Helps avoid human error if you typo your desired target dir DevCheck won't know any better and create it for you. That could have unintentional undesirable side effects.

RECOMMEND: Change line 1972 to

        Write-Host "...ERROR: $fileDir doesn't exist" -ForegroundColor Red -BackgroundColor Black
        $global:issues++
        return $false

and add at line 2050.5

# Ensure .temp and .user exist
$null = Get-TempPath
$null = Get-UserPath

[guimafelipe]

...\.user directory's created by DevCheck but could be a timing thing, or simply one tells DevCheck to only download nuget.exe and not do other things (which happen to create .user)

The nuget.exe is not put on the same ..\.user directory that is created by DevCheck.

Get-UserPath returns {Project-Root}\.user. But nuget.exe is set to be downloaded to .user from the global root path: C:\.user\nuget.exe. This is the file that ends up being created when I run .\tools\DevCheck\DevCheck.ps1 -NugetExeUpdate.

Should this be fixed to use the same .user directory from the project root that is created by DevCheck?

[DrusTheAxe]

The relative pathname's kinda icky, and unnecessary. DevCheck has functions

• Get-ProjectRoot
• Get-UserPath

among others. Make this

[String]$NugetExe=[IO.Path]::GetFullPath(Join-Path Get-UserPath "nuget.exe"),

Or is the GetFullPath unnecessary given Get-UserPath = Join-Path Get-ProjectRoot .user and Get-ProjectRoot = return (Get-Item $PSScriptRoot ).parent.parent.FullName ?

[DrusTheAxe]

NOTE: Get-UserPath ensures the .user directory exists before returning, creating if necessary. Is that a problem for a default parameter to DevCheck?

If so then make it

[String]$NugetExe=[IO.Path]::GetFullPath(Join-Path Get-ProjectRoot ".user\nuget.exe"),

[guimafelipe]

The main complication here is that the Get-ProjectRoot is not defined yet in the script at the moment the default value for the parameter is processes, so we can't simply call it there. I used the relative path for not overcomplicating it.

[DrusTheAxe]

Ah. Good point.

But please do the absolute filename trick for clarity (for the end user)

[String]$NugetExe=[IO.Path]::GetFullPath(Join-Path $PSScriptRoot "..\..\.user\nuget.exe"),