Update TabWindow.cpp #338
Open
Update TabWindow.cpp #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In project Windows-classic-samples/Samples/Win7Samples/multimedia/DirectWrite/HelloWorld, when processing message == WM_CREATE in TabWindow::WndProc(...), TabWindow fails to save its USERDATA with a ::SetWindowLongPtrW(hwnd, GWLP_USERDATA, PtrToUlong(pTabWindow)) call (file TabWindow.cpp, line 286), and consequently fails to initialize pTabWindow when processing later the WM_SIZE message. As the debugger reports an access violation exception in the _SCRT_STARTUP_WWINMAIN-branch routine, the error is hard to identify for beginner programmers. Use a standard-compliant reinterpret_cast<LONG_PTR>(pTabWindow).
zhuman
approved these changes
Aug 23, 2024
zhuman
left a comment
zhuman
left a comment
There was a problem hiding this comment.
Good catch, thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In project Windows-classic-samples/Samples/Win7Samples/multimedia/DirectWrite/HelloWorld, when processing message == WM_CREATE in TabWindow::WndProc(...), TabWindow fails to save its USERDATA with a ::SetWindowLongPtrW(hwnd, GWLP_USERDATA, PtrToUlong(pTabWindow)) call (file TabWindow.cpp, line 286), and consequently fails to initialize pTabWindow when processing later the WM_SIZE message.
As the debugger reports an access violation exception in the _SCRT_STARTUP_WWINMAIN-branch routine, the error is hard to identify for beginner programmers.
Use a standard-compliant reinterpret_cast<LONG_PTR>(pTabWindow).