Remove the unnecessary definitions in the csproj#2183
Open
0x5bfa wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Make sure to enable the "hide whitespace" option in the diff view. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR simplifies the WinUIGallery project configuration by consolidating content inclusion logic into the main .csproj and removing the separate ContentIncludes.props file.
Changes:
- Refactored
WinUIGallery.csprojto use glob-basedContent/Noneupdates and removed large explicit item lists. - Removed
WinUIGallery/ContentIncludes.propsand updated guidance docs accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| WinUIGallery/WinUIGallery.csproj | Consolidates content inclusion/copy behavior into the project file and removes previous granular item removals. |
| WinUIGallery/ContentIncludes.props | Deleted; prior content include/remove logic is no longer imported. |
| .github/copilot-instructions.md | Updates docs to no longer reference ContentIncludes.props for snippet inclusion. |
Comment on lines
+104
to
+105
| <Content Update="Assets\**" CopyToOutputDirectory="PreserveNewest" /> | ||
| <Content Remove="Assets\**\*.cs" /> |
Contributor
Author
There was a problem hiding this comment.
AFAIK assets are supposed to be included as Content not None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compiledefinitions for XAML filesContentdefinitions for image files & sample code snippetsHow Has This Been Tested?