Update to Windows App SDK 1.8#1012
Draft
michael-hawker wants to merge 1 commit intomicrosoft:winappsdk/mainfrom
Draft
Update to Windows App SDK 1.8#1012michael-hawker wants to merge 1 commit intomicrosoft:winappsdk/mainfrom
michael-hawker wants to merge 1 commit intomicrosoft:winappsdk/mainfrom
Conversation
- Bump version to 1.4.0 - Uses Microsoft.WindowsAppSDK.WinUI meta package only version 1.8.260204000 - Removes explicit WebView2 dependency - Updates Microsoft.Windows.SDK.BuildTools to 10.0.28000.1-RTM - Updates CsWinRT to 2.2.0 and centralizes as build prop in WindowsAppSdk.common.props
|
This won't work since the C++ projects require all the transitive dependencies to be added. However, you should be able to just update the nuspec file only and get rid of all the other changes. This relies on binary compatibility, which is discussed here - microsoft/WindowsAppSDK#6250 - I am pretty sure 1.8 will not have removed and APIs used by Win2D so it should be fine that Win2D is built against 1.6 but uses 1.8 for the runtime (and in fact no-one has thought to worry about this before). Alternatively, I have a full local build fix (including tests and docs) here - #1014. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to get the build script to run locally, seems like it's pinging an ADO that may not be turned on atm? Figured I could try at least creating the draft PR here and see what happens.
FYI @Sergio0694, think you may have helped with this the last time, so let me know if any of this looks weird or if you have tips on building the repo.
Fixes #1000, #998
Fixes microsoft/microsoft-ui-xaml#11002
This also moves from the whole WindowsAppSdk Package to just the WinUI package, which I think is the main requirement for Win2D? It also gets rid of the WebView2 package which is transitively included through WinUI. I assume was included here earlier to workaround prior migration issues in 1.6 but isn't actually required of Win2D.