chore: Update outdated GitHub Actions versions#1676
chore: Update outdated GitHub Actions versions#1676pgoslatara wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions used in the repository’s workflows to newer major versions, aiming to keep CI automation current and compatible.
Changes:
- Bump
actions/staletov10in the stale issues/PRs workflow. - Bump
actions/checkouttov6in the link checker and Azure Static Web Apps workflows. - Bump
peter-evans/create-issue-from-filetov6in the link checker workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/stale.yml |
Updates actions/stale major version used to mark items stale. |
.github/workflows/links.yml |
Updates checkout and issue-creation actions for scheduled link checking. |
.github/workflows/azure-static-web-apps-ashy-river-0debb7803.yml |
Updates checkout action in the Azure Static Web Apps CI/CD workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: Azure/static-web-apps-deploy@v1 | ||
| with: | ||
| azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_ASHY_RIVER_0DEBB7803 }} | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments) |
There was a problem hiding this comment.
Minor spelling/style: the comment says “Github integrations”; elsewhere GitHub is typically capitalized as “GitHub”. Consider updating for consistency.
| repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments) | |
| repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for GitHub integrations (i.e. PR comments) |
| steps: | ||
| - uses: actions/stale@v6 | ||
| - uses: actions/stale@v10 | ||
| with: |
There was a problem hiding this comment.
steps: expects its list items to be indented underneath it. As written, - uses: actions/stale@v10 is aligned with steps: which makes the workflow YAML invalid and will prevent this workflow from running. Indent the step entries (and their nested keys) by two additional spaces under steps:.
See below for a potential fix:
- uses: actions/stale@v10
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'This issue has not seen any action for a while! Closing for now, but it can be reopened at a later date.'
stale-pr-message: 'This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.'
stale-issue-label: 'no-issue-activity'
stale-pr-label: 'no-pr-activity'
days-before-close: -1
| on: workflow_dispatch | ||
|
|
||
| jobs: | ||
| build_and_deploy_job: | ||
| if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed') | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
This workflow is only triggered by workflow_dispatch, but both jobs are gated by if: conditions that only allow push / pull_request events. As a result, a manual run will skip all jobs and the workflow effectively does nothing. Update the on: block to include push/pull_request, or adjust/remove the job-level if: conditions to match the intended trigger.
2 participants
Description
This PR updates outdated GitHub Action versions to ensure compatibility and stability. The changes include updating
actions/checkoutfrom version v3 to v6 in two workflows, updatingactions/checkoutfrom v4 to v6 in another workflow, updatingactions/stalefrom v6 to v10, and updatingpeter-evans/create-issue-from-filefrom v5 to v6.Type of change