-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update eLxr distribution name #14032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fix eLxr name inconsistency across DistributionInfo.h and wsl-distribution.conf files
|
@rfu-cn: what's the background for this change ? To give some context, since |
Hi @OneBlue, results in the following error: There is no distribution with the supplied name. Only the commands using eLxr-12 work as expected: Since there is currently only a single eLxr version, I think removing the -12 suffix may make the user experience simpler and avoid potential confusion. Using "eLxr" alone should be unambiguous at this stage. BR/FuRong |
|
I was able to install the created distribution from the tar file stored elsewhere. I can now log into it via the terminal app. |
Hi @DoctorWho8 I agree that the generated rootfs itself appears to be working correctly. The behavior I am observing seems limited to the wsl --install / item-based installation path. In that case, although both elxr and elxr-12 can be used for installation, the distribution ends up being registered under the name elxr-12. As a result, management commands such as wsl --terminate and wsl --unregister only succeed when using that name. Given that there is currently only a single eLxr item, I was wondering whether it might be preferable to register the distribution simply as eLxr for now, to keep installation and management commands consistent. Version details could still be reflected in the friendly name and package version. Apologies for not considering this more carefully in the initial submission, and thank you for your guidance. |
Hello! |
Update eLxr distribution name to match DistributionInfo.h