Skip to content

[experiment] merge iterable decls in DOM #63193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakebailey wants to merge 1 commit into from
+436 −1,309
Closed

[experiment] merge iterable decls in DOM #63193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,011 changes: 243 additions & 768 deletions src/lib/dom.generated.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

670 changes: 161 additions & 509 deletions src/lib/webworker.generated.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/baselines/reference/checkJsxChildrenCanBeTupleType.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== checkJsxChildrenCanBeTupleType.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/contextualOverloadListFromArrayUnion.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ const resizeObserver = new ResizeObserver(([entry]) => {
> : ^^^^^^^^^^^^^^
>ResizeObserver : { new (callback: globalThis.ResizeObserverCallback): ResizeObserver; prototype: ResizeObserver; }
> : ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^
>([entry]) => { entry} : ([entry]: ResizeObserverEntry[]) => void
> : ^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>([entry]) => { entry} : ([entry]: Iterable<ResizeObserverEntry>) => void
> : ^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>entry : ResizeObserverEntry
> : ^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/contextuallyTypedJsxChildren.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== contextuallyTypedJsxChildren.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/divergentAccessorsTypes6.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ interface Element {

get style(): CSSStyleDeclaration;
>style : Symbol(Element.style, Decl(divergentAccessorsTypes6.ts, 2, 19), Decl(divergentAccessorsTypes6.ts, 3, 37))
>CSSStyleDeclaration : Symbol(CSSStyleDeclaration, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>CSSStyleDeclaration : Symbol(CSSStyleDeclaration, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

set style(cssText: string);
>style : Symbol(Element.style, Decl(divergentAccessorsTypes6.ts, 2, 19), Decl(divergentAccessorsTypes6.ts, 3, 37))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/divergentAccessorsTypes8.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ interface Element {

get style(): CSSStyleDeclaration;
>style : Symbol(Element.style, Decl(divergentAccessorsTypes8.ts, 12, 19), Decl(divergentAccessorsTypes8.ts, 13, 37))
>CSSStyleDeclaration : Symbol(CSSStyleDeclaration, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>CSSStyleDeclaration : Symbol(CSSStyleDeclaration, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

set style(cssText: string);
>style : Symbol(Element.style, Decl(divergentAccessorsTypes8.ts, 12, 19), Decl(divergentAccessorsTypes8.ts, 13, 37))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxElementType.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500 -> 5,000
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== jsxElementType.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxFragmentFactoryNoUnusedLocals.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000 -> 100,000
Symbol count: 50,000

=== jsxFragmentFactoryNoUnusedLocals.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxJsxsCjsTransformNestedSelfClosingChild(jsx=react-jsx).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== jsxJsxsCjsTransformNestedSelfClosingChild.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxJsxsCjsTransformNestedSelfClosingChild(jsx=react-jsxdev).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== jsxJsxsCjsTransformNestedSelfClosingChild.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxRuntimePragma(jsx=preserve).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== one.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxRuntimePragma(jsx=react).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== one.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxRuntimePragma(jsx=react-jsx).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== one.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/jsxRuntimePragma(jsx=react-jsxdev).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 100,000
Symbol count: 50,000

=== one.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_Worker.iterable.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
for (const [key, entry] of new FormData()) {
>key : Symbol(key, Decl(modularizeLibrary_Worker.iterable.ts, 0, 12))
>entry : Symbol(entry, Decl(modularizeLibrary_Worker.iterable.ts, 0, 16))
>FormData : Symbol(FormData, Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --))
>FormData : Symbol(FormData, Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --))

entry;
>entry : Symbol(entry, Decl(modularizeLibrary_Worker.iterable.ts, 0, 16))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/objectFromEntries.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const o2 = Object.fromEntries(new URLSearchParams());
>Object.fromEntries : Symbol(ObjectConstructor.fromEntries, Decl(lib.es2019.object.d.ts, --, --), Decl(lib.es2019.object.d.ts, --, --))
>Object : Symbol(Object, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
>fromEntries : Symbol(ObjectConstructor.fromEntries, Decl(lib.es2019.object.d.ts, --, --), Decl(lib.es2019.object.d.ts, --, --))
>URLSearchParams : Symbol(URLSearchParams, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>URLSearchParams : Symbol(URLSearchParams, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

const o3 = Object.fromEntries(new Map([[Symbol("key"), "value"]]));
>o3 : Symbol(o3, Decl(objectFromEntries.ts, 2, 5))
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/objectFromEntries.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ const o2 = Object.fromEntries(new URLSearchParams());
> : ^^^ ^^^^^^^^ ^^ ^^^ ^^^ ^^ ^^^ ^^^
>new URLSearchParams() : URLSearchParams
> : ^^^^^^^^^^^^^^^
>URLSearchParams : { new (init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams; prototype: URLSearchParams; }
> : ^^^^^^^ ^^^ ^^^ ^^^^^^^^^^^^^ ^^^
>URLSearchParams : { new (init?: Iterable<string[]> | Record<string, string> | string): URLSearchParams; prototype: URLSearchParams; }
> : ^^^^^^^ ^^^ ^^^ ^^^^^^^^^^^^^ ^^^

const o3 = Object.fromEntries(new Map([[Symbol("key"), "value"]]));
>o3 : { [k: string]: string; }
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/sourceMapWithMultipleFilesWithFileEndingWithInterface.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace M {
>X : Symbol(X, Decl(a.ts, 1, 14))
}
interface Navigator {
>Navigator : Symbol(Navigator, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(a.ts, 2, 1))
>Navigator : Symbol(Navigator, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(a.ts, 2, 1))

getGamepads(func?: any): any;
>getGamepads : Symbol(Navigator.getGamepads, Decl(lib.dom.d.ts, --, --), Decl(a.ts, 3, 21))
Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/truthinessCallExpressionCoercion2.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,10 +520,10 @@ function checksConsole() {
> : ^^^^^^^
>firebug : any
> : ^^^
>(window.console.error && window.console.table) : (tabularData?: any, properties?: string[]) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>window.console.error && window.console.table : (tabularData?: any, properties?: string[]) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>(window.console.error && window.console.table) : (tabularData?: any, properties?: Iterable<string>) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>window.console.error && window.console.table : (tabularData?: any, properties?: Iterable<string>) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>window.console.error : (...data: any[]) => void
> : ^^^^ ^^ ^^^^^
>window.console : Console
Expand All @@ -534,16 +534,16 @@ function checksConsole() {
> : ^^^^^^^
>error : (...data: any[]) => void
> : ^^^^ ^^ ^^^^^
>window.console.table : (tabularData?: any, properties?: string[]) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>window.console.table : (tabularData?: any, properties?: Iterable<string>) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>window.console : Console
> : ^^^^^^^
>window : Window & typeof globalThis
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^
>console : Console
> : ^^^^^^^
>table : (tabularData?: any, properties?: string[]) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
>table : (tabularData?: any, properties?: Iterable<string>) => void
> : ^ ^^^ ^^ ^^^ ^^^^^
}

function checksPropertyAccess() {
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/tsxReactEmitSpreadAttribute(target=es2018).types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Assignability cache: 2,500
Type Count: 10,000
Instantiation count: 100,000
Symbol count: 50,000 -> 100,000
Symbol count: 50,000

=== test.tsx ===
/// <reference path="react16.d.ts" />
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/typedArrays-es5(target=es2015).symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const int8Array = new Int8Array(1);

const nodeList = new NodeList();
>nodeList : Symbol(nodeList, Decl(typedArrays-es5.ts, 15, 5))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

[...nodeList];
>nodeList : Symbol(nodeList, Decl(typedArrays-es5.ts, 15, 5))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/typedArrays-es5(target=es5).symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const int8Array = new Int8Array(1);

const nodeList = new NodeList();
>nodeList : Symbol(nodeList, Decl(typedArrays-es5.ts, 15, 5))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

[...nodeList];
>nodeList : Symbol(nodeList, Decl(typedArrays-es5.ts, 15, 5))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/typedArrays-es6.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const int8Array = new Int8Array(1);

const nodeList = new NodeList();
>nodeList : Symbol(nodeList, Decl(typedArrays-es6.ts, 15, 5))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
>NodeList : Symbol(NodeList, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))

[...nodeList];
>nodeList : Symbol(nodeList, Decl(typedArrays-es6.ts, 15, 5))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/webworkerIterable.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ importScripts("")
// This should not raise a compiler error
const f = new FormData()
>f : Symbol(f, Decl(webworkerIterable.ts, 4, 5))
>FormData : Symbol(FormData, Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --))
>FormData : Symbol(FormData, Decl(lib.webworker.d.ts, --, --), Decl(lib.webworker.d.ts, --, --))

for (const element of f) {
>element : Symbol(element, Decl(webworkerIterable.ts, 5, 10))
Expand Down