Skip to content

Conversation

@jakebailey
Copy link
Member

5.9 is a little late, and a bunch of DOM doc improvements have been made.

Update to the DOM lib as 2025-06-18 at https://github.com/microsoft/TypeScript-DOM-lib-generator/tree/99c595280da56d2d1e4c44c5c2d6241042d0da42. I'm choosing this slightly older commit on purpose in order to avoid pulling in the partially incomplete CSS type changes still happening in that repo.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 2, 2025
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: happen
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/happen/happen-tests.ts
  21:1  error  TypeScript@local expected type to be:
  MouseEvent
got:
  PointerEvent  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250701/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250701/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: rails__ujs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rails__ujs/rails__ujs-tests.ts
  42:9  error  TypeScript@local expected type to be:
  MouseEvent
got:
  PointerEvent  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250701/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.32_typescript@5.9.0-dev.20250701/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 195,338k (± 0.96%) 196,019k (± 0.75%) ~ 193,026k 196,686k p=0.128 n=6
Parse Time 1.59s (± 1.45%) 1.59s (± 1.19%) ~ 1.56s 1.61s p=0.871 n=6
Bind Time 0.88s (± 2.08%) 0.88s (± 0.72%) ~ 0.87s 0.89s p=1.000 n=6
Check Time 11.87s (± 0.58%) 11.85s (± 0.55%) ~ 11.79s 11.98s p=1.000 n=6
Emit Time 3.36s (± 3.92%) 3.30s (± 0.59%) ~ 3.29s 3.34s p=0.570 n=6
Total Time 17.71s (± 0.50%) 17.62s (± 0.41%) ~ 17.55s 17.76s p=0.128 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 57 +1 (+ 1.79%) ~ ~ p=0.001 n=6
Symbols 948,753 948,912 +159 (+ 0.02%) ~ ~ p=0.001 n=6
Types 410,846 410,889 +43 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 1,225,245k (± 0.01%) 1,226,497k (± 0.00%) +1,253k (+ 0.10%) 1,226,439k 1,226,603k p=0.005 n=6
Parse Time 7.93s (± 0.96%) 7.96s (± 1.20%) ~ 7.82s 8.08s p=0.688 n=6
Bind Time 2.28s (± 0.71%) 2.29s (± 0.60%) ~ 2.27s 2.30s p=0.934 n=6
Check Time 38.21s (± 0.55%) 38.09s (± 0.53%) ~ 37.86s 38.38s p=0.470 n=6
Emit Time 17.87s (± 0.60%) 17.80s (± 0.36%) ~ 17.71s 17.86s p=0.173 n=6
Total Time 66.30s (± 0.44%) 66.14s (± 0.42%) ~ 65.83s 66.61s p=0.336 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,509,183 2,509,481 +298 (+ 0.01%) ~ ~ p=0.001 n=6
Types 892,716 892,733 +17 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,804,438k (± 0.00%) 2,805,375k (± 0.00%) +937k (+ 0.03%) 2,805,222k 2,805,523k p=0.005 n=6
Parse Time 10.49s (± 0.17%) 10.49s (± 0.46%) ~ 10.42s 10.56s p=1.000 n=6
Bind Time 2.73s (± 0.71%) 2.73s (± 0.59%) ~ 2.71s 2.75s p=0.868 n=6
Check Time 102.69s (± 2.29%) 102.70s (± 1.95%) ~ 100.55s 105.24s p=1.000 n=6
Emit Time 0.38s (± 1.08%) 0.37s (± 1.41%) 🟩-0.01s (- 3.08%) 0.36s 0.37s p=0.007 n=6
Total Time 116.29s (± 2.03%) 116.29s (± 1.72%) ~ 114.17s 118.83s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,081 1,227,081 ~ ~ ~ p=1.000 n=6
Types 267,474 267,474 ~ ~ ~ p=1.000 n=6
Memory used 3,097,463k (± 0.03%) 2,609,136k (±14.49%) ~ 2,364,119k 3,097,853k p=0.093 n=6
Parse Time 6.71s (± 0.66%) 6.55s (± 1.28%) -0.16s (- 2.38%) 6.48s 6.71s p=0.020 n=6
Bind Time 2.14s (± 1.52%) 2.14s (± 1.61%) ~ 2.09s 2.19s p=0.936 n=6
Check Time 42.88s (± 0.42%) 42.75s (± 0.53%) ~ 42.45s 43.15s p=0.336 n=6
Emit Time 3.43s (± 2.42%) 3.54s (± 3.81%) ~ 3.36s 3.68s p=0.173 n=6
Total Time 55.15s (± 0.38%) 54.99s (± 0.59%) ~ 54.53s 55.49s p=0.378 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,081 1,227,081 ~ ~ ~ p=1.000 n=6
Types 267,474 267,474 ~ ~ ~ p=1.000 n=6
Memory used 3,039,813k (± 9.79%) 3,040,314k (± 9.78%) ~ 2,433,050k 3,163,201k p=1.000 n=6
Parse Time 8.52s (± 0.93%) 8.57s (± 1.24%) ~ 8.38s 8.70s p=0.229 n=6
Bind Time 2.67s (± 1.59%) 2.70s (± 1.06%) ~ 2.67s 2.73s p=0.294 n=6
Check Time 53.25s (± 0.38%) 53.27s (± 0.26%) ~ 53.12s 53.51s p=0.936 n=6
Emit Time 4.42s (± 1.85%) 4.38s (± 3.28%) ~ 4.20s 4.57s p=0.575 n=6
Total Time 68.85s (± 0.31%) 68.91s (± 0.27%) ~ 68.68s 69.21s p=0.575 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,548 262,548 ~ ~ ~ p=1.000 n=6
Types 107,156 107,156 ~ ~ ~ p=1.000 n=6
Memory used 441,889k (± 0.00%) 441,901k (± 0.01%) ~ 441,798k 441,978k p=0.810 n=6
Parse Time 3.54s (± 1.02%) 3.54s (± 0.67%) ~ 3.51s 3.58s p=1.000 n=6
Bind Time 1.32s (± 1.25%) 1.32s (± 0.89%) ~ 1.31s 1.34s p=1.000 n=6
Check Time 18.86s (± 0.38%) 18.89s (± 0.34%) ~ 18.81s 18.95s p=0.519 n=6
Emit Time 1.51s (± 0.54%) 1.53s (± 0.92%) +0.02s (+ 1.10%) 1.51s 1.55s p=0.048 n=6
Total Time 25.22s (± 0.37%) 25.27s (± 0.23%) ~ 25.20s 25.33s p=0.261 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,367 225,367 ~ ~ ~ p=1.000 n=6
Types 94,290 94,290 ~ ~ ~ p=1.000 n=6
Memory used 371,050k (± 0.01%) 371,062k (± 0.01%) ~ 371,036k 371,107k p=0.470 n=6
Parse Time 2.32s (± 1.29%) 2.32s (± 0.72%) ~ 2.30s 2.34s p=0.871 n=6
Bind Time 1.33s (± 1.40%) 1.33s (± 1.10%) ~ 1.32s 1.36s p=1.000 n=6
Check Time 13.67s (± 0.48%) 13.66s (± 0.09%) ~ 13.64s 13.67s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 17.32s (± 0.44%) 17.32s (± 0.20%) ~ 17.26s 17.36s p=0.748 n=6
vscode - node (v18.15.0, x64)
Errors 33 33 ~ ~ ~ p=1.000 n=6
Symbols 3,500,356 3,500,928 +572 (+ 0.02%) ~ ~ p=0.001 n=6
Types 1,177,633 1,177,752 +119 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,550,781k (± 0.01%) 3,552,323k (± 0.01%) +1,543k (+ 0.04%) 3,552,099k 3,552,554k p=0.005 n=6
Parse Time 15.04s (± 0.50%) 15.06s (± 0.94%) ~ 14.97s 15.35s p=0.748 n=6
Bind Time 4.90s (± 0.41%) 4.90s (± 0.67%) ~ 4.84s 4.93s p=0.936 n=6
Check Time 95.56s (± 3.53%) 97.11s (± 2.74%) ~ 93.75s 100.15s p=0.471 n=6
Emit Time 31.78s (± 9.24%) 32.58s (± 7.60%) ~ 30.86s 35.78s p=0.575 n=6
Total Time 147.28s (± 2.85%) 149.65s (± 2.15%) ~ 144.78s 154.58s p=0.298 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 318,025 318,397 +372 (+ 0.12%) ~ ~ p=0.001 n=6
Types 137,709 137,749 +40 (+ 0.03%) ~ ~ p=0.001 n=6
Memory used 472,230k (± 0.02%) 473,228k (± 0.01%) +998k (+ 0.21%) 473,142k 473,276k p=0.005 n=6
Parse Time 4.36s (± 0.55%) 4.35s (± 1.06%) ~ 4.31s 4.41s p=0.746 n=6
Bind Time 1.77s (± 0.83%) 1.78s (± 0.42%) ~ 1.77s 1.79s p=0.216 n=6
Check Time 20.82s (± 0.36%) 20.76s (± 0.28%) ~ 20.67s 20.81s p=0.126 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 26.96s (± 0.24%) 26.89s (± 0.26%) ~ 26.78s 27.00s p=0.109 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 665,979 666,090 +111 (+ 0.02%) ~ ~ p=0.001 n=6
Types 199,345 199,363 +18 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 570,373k (± 0.01%) 571,365k (± 0.04%) +992k (+ 0.17%) 571,151k 571,573k p=0.005 n=6
Parse Time 4.27s (± 0.72%) 4.26s (± 0.59%) ~ 4.22s 4.28s p=0.739 n=6
Bind Time 1.33s (± 0.56%) 1.34s (± 0.77%) ~ 1.32s 1.35s p=0.351 n=6
Check Time 19.88s (± 0.47%) 19.90s (± 0.25%) ~ 19.85s 19.99s p=0.873 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.02s p=0.405 n=6
Total Time 25.48s (± 0.42%) 25.50s (± 0.19%) ~ 25.41s 25.56s p=0.629 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jul 2, 2025
@DanielRosenwasser DanielRosenwasser merged commit 441655c into microsoft:main Jul 2, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jul 2, 2025
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61986/merge:

Something interesting changed - please have a look.

Details

facebook/lexical

5 of 16 projects failed to build with the old tsc and were ignored

tsconfig.json

@jakebailey jakebailey deleted the dom-update-2025-06-18 branch July 2, 2025 02:29
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants