Fixed crash on ConstructSignature when computing interactive inlay hints
#61973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash when computing interactive inlay hints by adding support for construct signatures.
- Added a new test case in tests/cases/fourslash/inlayHintsVariableTypes3.ts.
- Updated the corresponding baseline in tests/baselines/reference/inlayHintsVariableTypes3.baseline.
- Extended inlay hint processing in src/services/inlayHints.ts to handle construct signatures.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/fourslash/inlayHintsVariableTypes3.ts | New test case for construct signature inlay hints. |
| tests/baselines/reference/inlayHintsVariableTypes3.baseline | Baseline update reflecting the new inlay hint output. |
| src/services/inlayHints.ts | Added branch to process construct signatures in inlay hints. |
Andarist
force-pushed
the
fix/construct-signature-crash-inlay-hints
branch
from
d5a1c6e to
6f432d9
Compare
jakebailey
approved these changes
Jun 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #61965